8000 Scala 2.13.0 Cats-Effect 2.0.0-RC1 by Avasil · Pull Request #875 · monix/monix · GitHub
[go: up one dir, main page]

Skip to content

Scala 2.13.0 Cats-Effect 2.0.0-RC1 - #875

Merged
alexandru merged 37 commits into
monix:masterfrom
Avasil:cats-effect-2.0.0-M1-scala2.13
Sep 10, 2019
Merged

alexandru merged 37 commits into
monix:masterfrom
Avasil:cats-effect-2.0.0-M1-scala2.13

Conversation

@Avasil
@Avasil Avasil commented May 2, 2019
Copy link
Copy Markdown
Collaborator

Related to #862

@alexandru @oleg-py We have to figure out whether our next release is on top of cats-effect 2.0.0-M1 and/or 1.3.0. I think there are some binary incompatibilities in cats-effect 2.0

@Avasil Avasil mentioned this pull request May 2, 2019
@oleg-py
oleg-py commented May 13, 2019 •
Copy link
Copy Markdown
Collaborator

I think there are some binary incompatibilities in cats-effect 2.0

IIRC cats-effect 2.0 is binary compatible with 1.x on Scala 2.12, same as cats.

3.0 final will be on cats-effect 2.0, but we can roll RC3 with fixed locals for CE 1.x if CE 2.0 isn't yet final by that time.

@Avasil Avasil changed the title Scala 2.13-RC1, Cats-Effect 2.0.0-M1 Scala 2.13.0 Cats-Effect 2.0.0-M4 Jun 20, 2019
@xuwei-k
xuwei-k commented Jul 1, 2019
Copy link
Copy Markdown
Contributor

Any updates? 👀

@Avasil
Avasil commented Jul 1, 2019
Copy link
Copy Markdown
Collaborator Author

@xuwei-k I don't know why CI fails but we will probably wait with release for stable Cats-Effect support if we use 2.0 for Monix 3.0 (or 3.1)

Would it be helpful to release a snapshot version from this branch?

@niebloomj
Copy link
Copy Markdown

Any updates?

@Avasil
Avasil commented Jul 23, 2019
Copy link
Copy Markdown
Collaborator Author

@niebloomj I have a snapshot from this branch if you're interested: 3.0.0-eddc79d-SNAPSHOT

I'm not sure when stable Cats-Effect supporting 2.13 is released and I don't want to release on a milestone

@Avasil Avasil changed the title Scala 2.13.0 Cats-Effect 2.0.0-M4 Scala 2.13.0 Cats-Effect 2.0.0-RC1 Aug 8, 2019
@BalmungSan BalmungSan mentioned this pull request Aug 30, 2019
6 tasks done
Comment thread project/MimaFilters.scala

object MimaFilters {
lazy val changesFor_3_0_0__RC5: Seq[ProblemFilter] = Seq(
// Incompatible signatures should not cause linking problems.
Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be fine but we might want to repeat this test: typelevel/cats-effect#609 (review)

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we sure they don't cause linking problems?

What happened there?

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, it's due to the changed Parallel from Cats or something?

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If so, then there's nothing we can do there.

@alexandru
Copy link
Copy Markdown
Member

@Avasil see my PR: Avasil#4

@alexandru
Copy link
Copy Markdown
Member

The tests are now failing due to Mima, since we never published packages for 2.13.0.

@alexandru
Copy link
Copy Markdown
Member

We should only run Mima for the lowest version supported, in this case 2.11 and not for 2.13.

@alexandru
alexandru merged commit 987fe24 into monix:master Sep 10, 2019
@Avasil
Avasil deleted the cats-effect-2.0.0-M1-scala2.13 branch December 14, 2019 13:25
mdedetrich pushed a commit to mdedetrich/monix that referenced this pull request Mar 28, 2020
* Scala 2.13-RC1, Cats-Effect 2.0.0-M1

* Update travis configuration for Scala 2.13-RC1

* Remove unicode arrows

* fix compilation errors

* fix Observable docs

* Support for Scala 2.13.0

* Add contextShift in TaskLikeConversionsSuite

* fix tests

* update dependencies

* Fix unapplied method

* Fix unapplied method

* Update scalatest to  3.0.8

* Update minitest

* remove duplicated minitestVersion definition

* Update Parallel

* fix TaskParallelNewtype scaladoc

* Debug 2.13 error

* Run eval and reactive on 2.12

* Fix TaskAsyncAutoShiftJVMSuite

* Fix OverflowStrategyUnboundedConcurrencySuite

* revert CI changes

* disable mima check for 2.13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

0