8000 Extend ObservableLike with filterNot method (#800) by Otah · Pull Request #816 · monix/monix · GitHub
[go: up one dir, main page]

Skip to content

Conversation

@Otah
@Otah Otah commented Jan 21, 2019
Copy link
Copy Markdown
Contributor

Introducing ObservableLike.filterNot operation for 2.x series.

@alexandru
Copy link
Copy Markdown
Member

All code needs some test. Can you add a test?

Also if we add filterNot in 2.3, we need it in 3.0 as well.

@Otah
Otah commented Jan 22, 2019
Copy link
Copy Markdown
Contributor Author

Ah, yes, sorry for not adding the test. I will add it.

Regarding the 3.0, that’s my plan. However because in 3 series there is not only the simple filter(A=>Boolean) but also variants with Task, I haven’t yet had a chance to implement this for consistency.

Long story short, I will do both the tests and a separate PR for 3 series (to master, correct me if I am wrong). For now, I just need some time to do it.

Thanks!

@alexandru
alexandru commented Jan 22, 2019 •
Copy link
Copy Markdown
Member

I wouldn't worry about the Task variant in 3.0. Not sure if I want it, until somebody cries for it.

@Otah
Otah force-pushed the observable-filterNot branch from 20b5875 to 8a97765 Compare January 23, 2019 22:21
@Otah
Otah commented Jan 23, 2019
Copy link
Copy Markdown
Contributor Author

I have added a test suite. Basically, it is a copy of the test suite of the filter operation, but I have changed the modulo to be equal to 1 instead of 0.

If you think this is not a good way how to test it, I will surely welcome some hint what should I test. I haven't really got used to your test suite yet, so there is surely a chance I am doing it wrongly. Just let me know please.

I will prepare equivalent PR of this for series 3 in next couple of days.

@Otah
Otah commented Jan 25, 2019
Copy link
Copy Markdown
Contributor Author

Not sure why the build failed, seems like the Travis CI somehow timed out? The SBT build was passing locally.

I have opened a MR for series 3.x as well, see #819

@Avasil
Avasil commented Jan 26, 2019
Copy link
Copy Markdown
Collaborator

I've restarted the build, for the record it hung on:

�[0m[�[0minfo�[0m] �[0m�[32mmonix.reactive.internal.operators.MaxSuite�[0m�[0m
�[0m[�[0minfo�[0m] �[0m�[32m- should emit exactly the requested elements�[0m
�[0m[�[0minfo�[0m] �[0m�[32m- should work for synchronous observers�[0m
�[0m[�[0minfo�[0m] �[0m�[32m- should work for asynchronous observers�[0m
�[0m[�[0minfo�[0m] �[0m�[32m- should back-pressure all the way�[0m
�[0m[�[0minfo�[0m] �[0m�[32m- should protect user-level code�[0m
�[0m[�[0minfo�[0m] �[0m�[32m- should not break the contract on user-level error�[0m
�[0m[�[0minfo�[0m] �[0m�[32m- onError should work�[0m
�[0m[�[0minfo�[0m] �[0m�[33m- should stop on first onNext !!! IGNORED !!!�[0m
�[0m[�[0minfo�[0m] �[0m�[32m- should be cancelable�[0m
�[0m[�[0minfo�[0m] �[0m�[32m- empty observable should be empty�[0m

@Avasil
Avasil commented Jan 28, 2019
Copy link
Copy Markdown
Collaborator

Thank you @Otah :)

@Avasil
Avasil merged commit eeb467c into monix:series/2.x Jan 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

0