Repository navigation
Extend ObservableLike with filterNot method (#800) - #816
Conversation
|
All code needs some test. Can you add a test? Also if we add |
|
Ah, yes, sorry for not adding the test. I will add it. Regarding the 3.0, that’s my plan. However because in 3 series there is not only the simple Long story short, I will do both the tests and a separate PR for 3 series (to Thanks! |
|
I wouldn't worry about the |
20b5875 to
8a97765
Compare
|
I have added a test suite. Basically, it is a copy of the test suite of the If you think this is not a good way how to test it, I will surely welcome some hint what should I test. I haven't really got used to your test suite yet, so there is surely a chance I am doing it wrongly. Just let me know please. I will prepare equivalent PR of this for series 3 in next couple of days. |
|
Not sure why the build failed, seems like the Travis CI somehow timed out? The SBT build was passing locally. I have opened a MR for series 3.x as well, see #819 |
|
I've restarted the build, for the record it hung on: |
|
Thank you @Otah :) |
Introducing
ObservableLike.filterNotoperation for 2.x series.