Repository navigation
Add Sync & Async instances for Iterant - #600
Merged
Merged
Conversation
Collaborator
Author
|
@alexandru not sure why build fails, could you please take a look? |
Member
|
The build is timing out and it can do so in a piece of logic that wasn't timing out before, possibly due to the CPU being very busy (although I don't understand how, because I remember that I disabled testing in parallel, but those settings never worked properly anyway). The tests for |
Member
|
One problem are all the stack-safety checks in |
Member
|
The attempted fix was to disable them when running on top of Travis. |
This was referenced Mar 4, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #599
I went ahead and implemented
Asyncinstance too (under the assumption that callback will only be invoked once, so it just delegates to underlyingF). Couldn't doEffectthough in a similar way, because signature ofrunAsyncsort-of implies cardinality of 1.