8000 Add Iterant#sumL method by oleg-py · Pull Request #578 · monix/monix · GitHub
[go: up one dir, main page]

Skip to content

Add Iterant#sumL method - #578

Merged
alexandru merged 1 commit into
monix:masterfrom
oleg-py:iterant-suml
Jan 30, 2018
Merged

alexandru merged 1 commit into
monix:masterfrom
oleg-py:iterant-suml

Conversation

@oleg-py
@oleg-py oleg-py commented Jan 29, 2018
Copy link
Copy Markdown
Collaborator

Closes #570

This was easy. Although the only type that has Numeric, but not Monoid out of the box is Char.

@codecov
codecov Bot commented Jan 29, 2018
Copy link
Copy Markdown

Codecov Report

Merging #578 into master will increase coverage by 0.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #578      +/-   ##
==========================================
+ Coverage   90.62%   90.63%   +0.01%     
==========================================
  Files         369      369              
  Lines        9802     9803       +1     
  Branches     1840     1846       +6     
==========================================
+ Hits         8883     8885       +2     
+ Misses        919      918       -1

@alexandru
alexandru merged commit e49040f into monix:master Jan 30, 2018
@alexandru
Copy link
Copy Markdown
Member

@oleg-py on Numeric vs Monoid this is true, however it's about familiarity / integration with the standard library. People expect to do .sum on collection types.

@alexandru
Copy link
Copy Markdown
Member

We already have foldL taking a Monoid, not sure if you've seen it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

0