Repository navigation
Issue #563 - completeL should handle F[_] errors, mapEval should not - #567
Merged
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #567 +/- ##
==========================================
+ Coverage 90.57% 90.61% +0.03%
==========================================
Files 369 369
Lines 9782 9781 -1
Branches 1841 1857 +16
==========================================
+ Hits 8860 8863 +3
+ Misses 922 918 -4 |
Member
Author
|
@oleg-py Not waiting any longer on this PR, merging it directly to unblock your testing. Implementation seems fine to me - the internal variable is completely encapsulated. One note - |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #563 — fixed
completeLwith a reasonable penalty for doing that error handling, due to mutating a plain var.In case of this loop, it doesn't matter due to the inner workings of the loop being suspended and completely encapsulated. However this isn't an optimization that we can afford to do for operations returning
Iterant.Therefore, except for operations meant specifically for error handling, like
onErrorHandlingWith, the errors raised in theF[_]context should get handled by folding operations (ending with theLsuffix), one of which beingcompleteL.