8000 Consistent naming in Observable / Iterant by alexandru · Pull Request #411 · monix/monix · GitHub
[go: up one dir, main page]

Skip to content

Consistent naming in Observable / Iterant - #411

Merged
alexandru merged 8 commits into
monix:masterfrom
alexandru:scanEval
Aug 11, 2017
Merged

alexandru merged 8 commits into
monix:masterfrom
alexandru:scanEval

Conversation

@alexandru
@alexandru alexandru commented Aug 11, 2017 •
Copy link
Copy Markdown
Member

Work on naming consistency:

  • all fold-left-like (including scan and scanEval) operations taking an initial value should have the param named seed
  • all fold-left-like (including scan and scanEval) operations taking a function should name that function op
  • the Eval suffix (e.g. scanEval, mapEval) in the context of Observable should mean that the operator accepts an F[_] that implements Effect[F]
  • the Async suffix (e.g. mapAsync) should no longer be used
    • renamed mapAsync(parallelism: Int) to mapParallelUnordered
    • deleted the mapAsync alias for mapTask
    • renamed the mapAsync function in Consumer as well

@codecov
codecov Bot commented Aug 11, 2017 •
Copy link
Copy Markdown

Codecov Report

Merging #411 into master will increase coverage by <.01%.
The diff coverage is 94.73%.

@@            Coverage Diff             @@
##           master     #411      +/-   ##
==========================================
+ Coverage   88.36%   88.36%   +<.01%     
==========================================
  Files         338      338              
  Lines        9234     9243       +9     
  Branches     1244     1254      +10     
==========================================
+ Hits         8160     8168       +8     
- Misses       1074     1075       +1

@alexandru alexandru changed the title Add Iterant.scanEval Iterant.scanEval; Observable.scanEval, mapEval; converging on naming Aug 11, 2017
@alexandru alexandru changed the title Iterant.scanEval; Observable.scanEval, mapEval; converging on naming Task.fromEffect, Iterant.scanEval, Observable.scanEval+mapEval+naming Aug 11, 2017
@alexandru alexandru changed the title Task.fromEffect, Iterant.scanEval, Observable.scanEval+mapEval+naming Consistent naming in Observable / Iterant Aug 11, 2017
@alexandru
alexandru merged commit 5264e49 into monix:master Aug 11, 2017
@alexandru alexandru added this to the 3.0.0 milestone Jan 21, 2018
kpodsiad pushed a commit to kpodsiad/bloop that referenced this pull request Jul 30, 2021
observable.mapAsync ->observable.mapParallelUnordered
renamed in: monix/monix#411
kpodsiad pushed a commit to kpodsiad/bloop that referenced this pull request Jul 30, 2021
observable.mapAsync ->observable.mapParallelUnordered
renamed in: monix/monix#411
kpodsiad pushed a commit to kpodsiad/bloop that referenced this pull request Aug 5, 2021
observable.mapAsync ->observable.mapParallelUnordered
renamed in: monix/monix#411
dos65 pushed a commit to dos65/bloop that referenced this pull request Jun 7, 2022
  - NonFatal & Callback
  - Task.chooseFirstOf -> Task.racePair
    The result type changed from Future to Fiber and I must handle fiber cancelation instead future one

  - Task.gatherUnordered -> Task.parSequenceUnordered
  - Observable.mapAsync ->observable.mapParallelUnordered
      renamed in: monix/monix#411
  - Overriden apply in the FoldLeftConsumer is unnecessary. When deleted at master, everything works fine and tests are passing
  - Quicfix for monix/monix#724
    Added option will change the behaviour of task cancelling to the previous one. It's dirty and should be done better, but it is good enough for now, when there are still failing tests.
  - Bump bsp version
  - Use jsonrpc4s instead of scalameta jsonrpc
    Adjusting codebase required a lot of refactoring, but my main goal was to migrate so I tried to do as little changes as I could. For example, I didn't replace BloopLanguageServer with RpcServer for that reason.
  - Fix scribe adapter
  - Fix source hasher cancelation
dos65 pushed a commit to dos65/bloop that referenced this pull request Jul 4, 2022
  - NonFatal & Callback
  - Task.chooseFirstOf -> Task.racePair
    The result type changed from Future to Fiber and I must handle fiber cancelation instead future one

  - Task.gatherUnordered -> Task.parSequenceUnordered
  - Observable.mapAsync ->observable.mapParallelUnordered
      renamed in: monix/monix#411
  - Overriden apply in the FoldLeftConsumer is unnecessary. When deleted at master, everything works fine and tests are passing
  - Quicfix for monix/monix#724
    Added option will change the behaviour of task cancelling to the previous one. It's dirty and should be done better, but it is good enough for now, when there are still failing tests.
  - Bump bsp version
  - Use jsonrpc4s instead of scalameta jsonrpc
    Adjusting codebase required a lot of refactoring, but my main goal was to migrate so I tried to do as little changes as I could. For example, I didn't replace BloopLanguageServer with RpcServer for that reason.
  - Fix scribe adapter
  - Fix source hasher cancelation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

0