Repository navigation
Consistent naming in Observable / Iterant - #411
Merged
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #411 +/- ##
==========================================
+ Coverage 88.36% 88.36% +<.01%
==========================================
Files 338 338
Lines 9234 9243 +9
Branches 1244 1254 +10
==========================================
+ Hits 8160 8168 +8
- Misses 1074 1075 +1 |
kpodsiad
pushed a commit
to kpodsiad/bloop
that referenced
this pull request
Jul 30, 2021
observable.mapAsync ->observable.mapParallelUnordered renamed in: monix/monix#411
kpodsiad
pushed a commit
to kpodsiad/bloop
that referenced
this pull request
Jul 30, 2021
observable.mapAsync ->observable.mapParallelUnordered renamed in: monix/monix#411
kpodsiad
pushed a commit
to kpodsiad/bloop
that referenced
this pull request
Aug 5, 2021
observable.mapAsync ->observable.mapParallelUnordered renamed in: monix/monix#411
dos65
pushed a commit
to dos65/bloop
that referenced
this pull request
Jun 7, 2022
- NonFatal & Callback
- Task.chooseFirstOf -> Task.racePair
The result type changed from Future to Fiber and I must handle fiber cancelation instead future one
- Task.gatherUnordered -> Task.parSequenceUnordered
- Observable.mapAsync ->observable.mapParallelUnordered
renamed in: monix/monix#411
- Overriden apply in the FoldLeftConsumer is unnecessary. When deleted at master, everything works fine and tests are passing
- Quicfix for monix/monix#724
Added option will change the behaviour of task cancelling to the previous one. It's dirty and should be done better, but it is good enough for now, when there are still failing tests.
- Bump bsp version
- Use jsonrpc4s instead of scalameta jsonrpc
Adjusting codebase required a lot of refactoring, but my main goal was to migrate so I tried to do as little changes as I could. For example, I didn't replace BloopLanguageServer with RpcServer for that reason.
- Fix scribe adapter
- Fix source hasher cancelation
dos65
pushed a commit
to dos65/bloop
that referenced
this pull request
Jul 4, 2022
- NonFatal & Callback
- Task.chooseFirstOf -> Task.racePair
The result type changed from Future to Fiber and I must handle fiber cancelation instead future one
- Task.gatherUnordered -> Task.parSequenceUnordered
- Observable.mapAsync ->observable.mapParallelUnordered
renamed in: monix/monix#411
- Overriden apply in the FoldLeftConsumer is unnecessary. When deleted at master, everything works fine and tests are passing
- Quicfix for monix/monix#724
Added option will change the behaviour of task cancelling to the previous one. It's dirty and should be done better, but it is good enough for now, when there are still failing tests.
- Bump bsp version
- Use jsonrpc4s instead of scalameta jsonrpc
Adjusting codebase required a lot of refactoring, but my main goal was to migrate so I tried to do as little changes as I could. For example, I didn't replace BloopLanguageServer with RpcServer for that reason.
- Fix scribe adapter
- Fix source hasher cancelation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Work on naming consistency:
scanandscanEval) operations taking an initial value should have the param namedseedscanandscanEval) operations taking a function should name that functionopEvalsuffix (e.g.scanEval,mapEval) in the context ofObservableshould mean that the operator accepts anF[_]that implementsEffect[F]Asyncsuffix (e.g.mapAsync) should no longer be usedmapAsync(parallelism: Int)tomapParallelUnorderedmapAsyncalias formapTaskmapAsyncfunction inConsumeras well