[go: up one dir, main page]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

List RFC revisions #3490

Merged
merged 6 commits into from
Sep 6, 2024
Merged

List RFC revisions #3490

merged 6 commits into from
Sep 6, 2024

Conversation

carolynzech
Copy link
Contributor

Addresses @jaisnan's feedback on list RFC--change human output to pretty and fix Kani version typo.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT licenses.

@carolynzech carolynzech requested a review from a team as a code owner September 4, 2024 14:50
jaisnan
jaisnan reviewed Sep 4, 2024
View reviewed changes
Copy link
Contributor
@jaisnan jaisnan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost there! Just a few small points left to address

rfc/src/rfcs/0012-list.md Outdated Show resolved Hide resolved
rfc/src/rfcs/0012-list.md Show resolved Hide resolved
celinval
celinval reviewed Sep 4, 2024
View reviewed changes
Copy link
Contributor
@celinval celinval left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few comments

rfc/src/rfcs/0012-list.md Outdated Show resolved Hide resolved
rfc/src/rfcs/0012-list.md Outdated Show resolved Hide resolved
rfc/src/rfcs/0012-list.md Outdated Show resolved Hide resolved
rfc/src/rfcs/0012-list.md Outdated Show resolved Hide resolved
rfc/src/rfcs/0012-list.md Outdated Show resolved Hide resolved
rfc/src/rfcs/0012-list.md Outdated Show resolved Hide resolved
jaisnan
jaisnan approved these changes Sep 4, 2024
View reviewed changes
Copy link
Contributor
@jaisnan jaisnan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving under the assumption that the schemas will be added to documentation sooner rather than later 👍

@carolynzech
Copy link
Contributor Author
carolynzech commented Sep 4, 2024 •
edited
Loading

Approving under the assumption that the schemas will be added to documentation sooner rather than later 👍

@jaisnan Yes, I'll make sure that the first release of this has schema documentation.

@carolynzech carolynzech added this pull request to the merge queue Sep 6, 2024
Merged via the queue into model-checking:main with commit 2536f64 Sep 6, 2024
27 checks passed
@carolynzech carolynzech deleted the list-rfc-feedback branch September 6, 2024 19:26
@celinval celinval mentioned this pull request Oct 8, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@celinval celinval celinval approved these changes

@jaisnan jaisnan jaisnan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@carolynzech @celinval @jaisnan