Fix 0 httpTimeout for logger webhook #20653
Merged
+24
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, not setting http.Config.HTTPTimeout for logger webhook was resulting in a timeout of 0, and causing "deadline exceeded" errors in log webhook. This change introduces a new env variable for configuring log webhook timeout and more importantly sets it when the config is initialised.
|
This fixes #20630 |
harshavardhana
approved these changes
Nov 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, not setting http.Config.HTTPTimeout for logger webhook was resulting in a timeout of 0, and causing "deadline exceeded" errors in log webhook.
This change introduces a new env variable for configuring log webhook timeout and more importantly sets it when the config is initialised.
Community Contribution License
All community contributions in this pull request are licensed to the project maintainers
under the terms of the Apache 2 license.
By creating this pull request I represent that I have the right to license the
contributions to the project maintainers under the Apache 2 license.
Description
Motivation and Context
How to test this PR?
Types of changes
Checklist:
commit-idorPR #here)