Make DeadlineConn http.Listener compatible #20635
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
http likes to slap an infinite read deadline on a connection and doing a blocking read while the response is being written. This effectively means that a read deadline becomes the request response deadline. Instead of enforcing our own timeout, we pass it through and keep "infinite deadline" sticky on connections. We do however still "record" when reads are aborted, so we never overwrite that. For the deadline to be effective, the http server should have `ReadTimeout` and `IdleTimeout` set.
zveinn
approved these changes
Nov 12, 2024
harshavardhana
approved these changes
Nov 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
http likes to slap an infinite read deadline on a connection and doing a blocking read while the response is being written.
This effectively means that a read deadline becomes the request response deadline.
Instead of enforcing our own timeout, we pass it through and keep "infinite deadline" sticky on connections.
We do however still "record" when reads are aborted, so we never overwrite that.
For the deadline to be effective, the http server should have
ReadTimeoutandIdleTimeoutset.How to test this PR?
Change
minio/internal/http/listener.go
Line 76 in 91805bc
Types of changes