[go: up one dir, main page]

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[godot-cpp] Update to 4.3 #41246

Merged

Conversation

LilyWangLL
Copy link
Contributor

Update godot-cpp to 4.3.
Usage passed on x64-windows.

  • Changes comply with the maintainer guide.
  • SHA512s are updated for each updated download.
  • The "supports" clause reflects platforms that may be fixed by this new version.
  • Any fixed CI baseline entries are removed from that file.
  • Any patches that are no longer applied are deleted from the port's directory.
  • When updating the upstream version, the "port-version" is reset (removed from vcpkg.json).
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Only one version is added to each modified port's versions file.

@LilyWangLL LilyWangLL added info:internal This PR or Issue was filed by the vcpkg team. category:port-update The issue is with a library, which is requesting update new revision labels Sep 29, 2024
@LilyWangLL LilyWangLL mentioned this pull request Sep 29, 2024
7 tasks
@LilyWangLL LilyWangLL marked this pull request as ready for review September 29, 2024 10:16
@Cheney-W Cheney-W added the info:reviewed Pull Request changes follow basic guidelines label Sep 29, 2024
Comment on lines -9 to 10
-cmake_minimum_required(VERSION 3.12)
-cmake_minimum_required(VERSION 3.13)
+cmake_minimum_required(VERSION 3.19)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why does this need to be patched at all?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change from PR #37931 which creates this port.

@JavierMatosD JavierMatosD merged commit cb0934f into microsoft:master Sep 30, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-update The issue is with a library, which is requesting update new revision info:internal This PR or Issue was filed by the vcpkg team. info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants