[go: up one dir, main page]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[libyuv] Fix build error on macOS with llvm 19 #41174

Merged
merged 1 commit into from
Sep 30, 2024
Merged

[libyuv] Fix build error on macOS with llvm 19 #41174

merged 1 commit into from
Sep 30, 2024
+10 −5

Conversation

ChaseKnowlden
Copy link
Contributor
@ChaseKnowlden ChaseKnowlden commented Sep 25, 2024 •
edited by WangWeiLin-MV
Loading
  • Changes comply with the maintainer guide.
  • SHA512s are updated for each updated download.
  • The "supports" clause reflects platforms that may be fixed by this new version.
  • Any fixed CI baseline entries are removed from that file.
  • Any patches that are no longer applied are deleted from the port's directory.
  • When updating the upstream version, the "port-version" is reset (removed from vcpkg.json).
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Only one version is added to each modified port's versions file.

LLVM clang causes an undefined symbol error after updating to llvm 19 when building Ladybird.

@ChaseKnowlden ChaseKnowlden force-pushed the libyuv-llvm19 branch 2 times, most recently from 73f59fa to a6c527e Compare September 25, 2024 20:57
@WangWeiLin-MV WangWeiLin-MV added the category:port-update The issue is with a library, which is requesting update new revision label Sep 26, 2024
@WangWeiLin-MV
Copy link
Contributor

I changed this to draft because the build is broken; please feel free to mark 'Ready for review' when it's working and you're happy with it.

@WangWeiLin-MV WangWeiLin-MV marked this pull request as draft September 26, 2024 02:34
@ChaseKnowlden ChaseKnowlden marked this pull request as ready for review September 26, 2024 19:37
@ChaseKnowlden
Copy link
Contributor Author

CI is passing!

@ChaseKnowlden
Copy link
Contributor Author

All CIs fixed.

@ChaseKnowlden ChaseKnowlden mentioned this pull request Sep 27, 2024
Open
@WangWeiLin-MV WangWeiLin-MV added the info:reviewed Pull Request changes follow basic guidelines label Sep 29, 2024
@JavierMatosD JavierMatosD merged commit 2960d7d into microsoft:master Sep 30, 2024
16 checks passed
@ChaseKnowlden ChaseKnowlden deleted the libyuv-llvm19 branch September 30, 2024 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WangWeiLin-MV WangWeiLin-MV WangWeiLin-MV approved these changes

Assignees

@WangWeiLin-MV WangWeiLin-MV

Labels
category:port-update The issue is with a library, which is requesting update new revision info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ChaseKnowlden @WangWeiLin-MV @JavierMatosD