[go: up one dir, main page]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[openvino] update to 2024.4.0 #41077

Merged
merged 3 commits into from
Sep 30, 2024
Merged

[openvino] update to 2024.4.0 #41077

merged 3 commits into from
Sep 30, 2024
+23 −46

Conversation

culhatsker
Copy link
Contributor
  • Changes comply with the maintainer guide.
  • SHA512s are updated for each updated download.
  • The "supports" clause reflects platforms that may be fixed by this new version.
  • Any fixed CI baseline entries are removed from that file.
  • Any patches that are no longer applied are deleted from the port's directory.
  • When updating the upstream version, the "port-version" is reset (removed from vcpkg.json).
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Only one version is added to each modified port's versions file.

@culhatsker
Copy link
Contributor Author

I am investigating the arm_neon_android fail.
On the first sight it seems to be a ComputeLibrary issue, it fails to compile at src/core/NEON/kernels/arm_gemm/utils.hpp#L186 saying that there's no such register as x0.

@JonLiu1993 JonLiu1993 changed the title openvino/2024.4.0 update [openvino] update to 2024.4.0 Sep 20, 2024
@JonLiu1993 JonLiu1993 added the category:port-update The issue is with a library, which is requesting update new revision label Sep 20, 2024
@culhatsker
Copy link
Contributor Author

I disabled arm&android configuration cause latest ComputeLibrary has issues with it.
See ARM-software/ComputeLibrary#1141 for details

dg0yt
dg0yt reviewed Sep 24, 2024
View reviewed changes
ports/openvino/vcpkg.json Outdated Show resolved Hide resolved
@JonLiu1993
Copy link
Member

@culhatsker, Thanks for your PR, when I tested feature by command ./vcpkg install openvino[*]:x64-windows. I get this error, please take a look:

CMake Error at thirdparty/gflags/CMakeLists.txt:16 (add_subdirectory):
  The source directory

    F:/Feature-test/openvino/buildtrees/openvino/src/2024.4.0-73dc795f05.clean/thirdparty/gflags/gflags

  does not contain a CMakeLists.txt file.

@ilya-lavrenov
Copy link
Contributor

@culhatsker, Thanks for your PR, when I tested feature by command ./vcpkg install openvino[*]:x64-windows. I get this error, please take a look:

CMake Error at thirdparty/gflags/CMakeLists.txt:16 (add_subdirectory):
  The source directory

    F:/Feature-test/openvino/buildtrees/openvino/src/2024.4.0-73dc795f05.clean/thirdparty/gflags/gflags

  does not contain a CMakeLists.txt file.

need to add cmake option ENABLE_INTEL_NPU_INTERNAL=OFF

@culhatsker
Copy link
Contributor Author

Ok, I see that this issue also happens on x64-linux-dynamic triplet and I need to add the ENABLE_INTEL_NPU_INTERNAL=OFF option when npu feature is enabled.
I never checked all features cause I assumed that CI does this check for port updates shrugs

@culhatsker @dg0yt
Update ports/openvino/vcpkg.json
e20ab41 
Co-authored-by: Kai Pastor <dg0yt@darc.de>
@dg0yt
Copy link
Contributor
dg0yt commented Sep 29, 2024

thirdparty/gflags/CMakeLists.txt:16 (add_subdirectory):

If somethings needs gflags, it should take it from vcpkg.

@ilya-lavrenov
Copy link
Contributor

thirdparty/gflags/CMakeLists.txt:16 (add_subdirectory):

If somethings needs gflags, it should take it from vcpkg.

vcpkg enabled components do not require gflags.

@JonLiu1993
Copy link
Member

All features are tested successfully in x64-windows triplet.

@JonLiu1993 JonLiu1993 added the info:reviewed Pull Request changes follow basic guidelines label Sep 30, 2024
@JavierMatosD JavierMatosD merged commit 8ac2f04 into microsoft:master Sep 30, 2024
16 checks passed
@JavierMatosD JavierMatosD mentioned this pull request Sep 30, 2024
Draft
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dg0yt dg0yt dg0yt left review comments

@ilya-lavrenov ilya-lavrenov ilya-lavrenov approved these changes

@JonLiu1993 JonLiu1993 JonLiu1993 approved these changes

Assignees

@JonLiu1993 JonLiu1993

Labels
category:port-update The issue is with a library, which is requesting update new revision info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@culhatsker @JonLiu1993 @ilya-lavrenov @dg0yt @JavierMatosD