-
Notifications
You must be signed in to change notification settings - Fork 6.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[libvhdi] Use official build system #36809
base: master
Are you sure you want to change the base?
Conversation
c45ff3c
to
46422a5
Compare
3dfdad6
to
74bed36
Compare
66b57ea
to
de7100f
Compare
What work is left before this is ready to merge? I'd like to help get this merged. |
IIRC now there are several related ports which share the same pattern of carrying a set of common private libs. This is a problem for the static triplets. Packaging them all separately is a lot of work. |
I've tried to map out what private libraries need to be packaged taking account for recursive dependencies and I've come up with 18 of those libraries. (To support all currently existing libyal ports)
This PR has gotten quite large already, I think I'll create a new branch and cherry-pick the vcpkg-libyal-vstools and add a new port of a simple libyal library with no private dependencies like libcerror. |
The PR is large due to msbuild patching. It might make sense to rewrite the msbuild files with another mechanism. |
Can I ask why you disabled building with static CRT? |
IIRC the MSVC build only allows a DLL. This doesn't combine well with a static CRT. |
Is there any new progress? |
Keep open. |
No description provided.