[blaze] Add lapack and openmp features #36786
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@microsoft-github-policy-service agree |
Cheney-W
approved these changes
Feb 18, 2024
|
Please click the |
TomKatom
pushed a commit
to TomKatom/vcpkg
that referenced
this pull request
Feb 23, 2024
Hi, this PR adds two feature flags to Blaze to allow for a minimal 'core' installation: 1. `lapack`: LAPACK/BLAS is currently a default dependency, but its only required for certain matrix operations and `BLAZE_BLAS_MODE` which is off by default. See [CMakeLists.txt#L65-L75](https://bitbucket.org/blaze-lib/blaze/src/3156507a4b7a6a9cd413ef87df0a0aa2b1c697d9/CMakeLists.txt#lines-65:75). 2. `openmp`: The absence of this flag actually disables SMP support entirely, so it might be better to just use `smp` instead. Thoughts? I used `openmp` for consistency with the existing port which explicitly sets the threading library via `BLAZE_SMP_THREADS=OpenMP`. In any case, Blaze defaults to OpenMP and removes `BLAZE_SMP_THREADS` from cache when `BLAZE_SHARED_MEMORY_PARALLELIZATION` is turned off. See [CMakeLists.txt#L297-L304](https://bitbucket.org/blaze-lib/blaze/src/3156507a4b7a6a9cd413ef87df0a0aa2b1c697d9/CMakeLists.txt#lines-297:304). Both of these are still set as default features to ensure compatibility, though I think the default LAPACK REQUIRED as a reminder to package maintainers might be a bit excessive! If you're using LAPACK, you probably aren't relying on Blaze to import it for you. That's probably more of a discussion for upstream in any case. - [x] Changes comply with the [maintainer guide](https://github.com/microsoft/vcpkg-docs/blob/main/vcpkg/contributing/maintainer-guide.md). - [ ] ~~SHA512s are updated for each updated download.~~ - [ ] ~~The "supports" clause reflects platforms that may be fixed by this new version.~~ - [ ] ~~Any fixed [CI baseline](https://github.com/microsoft/vcpkg/blob/master/scripts/ci.baseline.txt) entries are removed from that file.~~ - [ ] ~~Any patches that are no longer applied are deleted from the port's directory.~~ - [x] The version database is fixed by rerunning `./vcpkg x-add-version --all` and committing the result. - [x] Only one version is added to each modified port's versions file.
Osyotr
pushed a commit
to Osyotr/vcpkg
that referenced
this pull request
Feb 26, 2024
Hi, this PR adds two feature flags to Blaze to allow for a minimal 'core' installation: 1. `lapack`: LAPACK/BLAS is currently a default dependency, but its only required for certain matrix operations and `BLAZE_BLAS_MODE` which is off by default. See [CMakeLists.txt#L65-L75](https://bitbucket.org/blaze-lib/blaze/src/3156507a4b7a6a9cd413ef87df0a0aa2b1c697d9/CMakeLists.txt#lines-65:75). 2. `openmp`: The absence of this flag actually disables SMP support entirely, so it might be better to just use `smp` instead. Thoughts? I used `openmp` for consistency with the existing port which explicitly sets the threading library via `BLAZE_SMP_THREADS=OpenMP`. In any case, Blaze defaults to OpenMP and removes `BLAZE_SMP_THREADS` from cache when `BLAZE_SHARED_MEMORY_PARALLELIZATION` is turned off. See [CMakeLists.txt#L297-L304](https://bitbucket.org/blaze-lib/blaze/src/3156507a4b7a6a9cd413ef87df0a0aa2b1c697d9/CMakeLists.txt#lines-297:304). Both of these are still set as default features to ensure compatibility, though I think the default LAPACK REQUIRED as a reminder to package maintainers might be a bit excessive! If you're using LAPACK, you probably aren't relying on Blaze to import it for you. That's probably more of a discussion for upstream in any case. - [x] Changes comply with the [maintainer guide](https://github.com/microsoft/vcpkg-docs/blob/main/vcpkg/contributing/maintainer-guide.md). - [ ] ~~SHA512s are updated for each updated download.~~ - [ ] ~~The "supports" clause reflects platforms that may be fixed by this new version.~~ - [ ] ~~Any fixed [CI baseline](https://github.com/microsoft/vcpkg/blob/master/scripts/ci.baseline.txt) entries are removed from that file.~~ - [ ] ~~Any patches that are no longer applied are deleted from the port's directory.~~ - [x] The version database is fixed by rerunning `./vcpkg x-add-version --all` and committing the result. - [x] Only one version is added to each modified port's versions file.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, this PR adds two feature flags to Blaze to allow for a minimal 'core' installation:
lapack: LAPACK/BLAS is currently a default dependency, but its only required for certain matrix operations andBLAZE_BLAS_MODEwhich is off by default. See CMakeLists.txt#L65-L75.openmp: The absence of this flag actually disables SMP support entirely, so it might be better to just usesmpinstead. Thoughts? I usedopenmpfor consistency with the existing port which explicitly sets the threading library viaBLAZE_SMP_THREADS=OpenMP. In any case, Blaze defaults to OpenMP and removesBLAZE_SMP_THREADSfrom cache whenBLAZE_SHARED_MEMORY_PARALLELIZATIONis turned off. See CMakeLists.txt#L297-L304.Both of these are still set as default features to ensure compatibility, though I think the default LAPACK REQUIRED as a reminder to package maintainers might be a bit excessive! If you're using LAPACK, you probably aren't relying on Blaze to import it for you. That's probably more of a discussion for upstream in any case.
SHA512s are updated for each updated download.The "supports" clause reflects platforms that may be fixed by this new version.Any fixed CI baseline entries are removed from that file.Any patches that are no longer applied are deleted from the port's directory../vcpkg x-add-version --alland committing the result.