8000 fix dictionary edge case by Cyan4973 · Pull Request #1865 · meta/zstd · GitHub
[go: up one dir, main page]

Skip to content

fix dictionary edge case - #1865

Merged
Cyan4973 merged 3 commits into
masterfrom
dev
Nov 4, 2019
Merged

Cyan4973 merged 3 commits into
masterfrom
dev

Conversation

@Cyan4973
@Cyan4973 Cyan4973 commented Nov 4, 2019
Copy link
Copy Markdown
Contributor

* Adds the fuzzer
* Adds an additional `InputType` for the fuzzer

I ran the fuzzer for about 10 minutes and it found 2 bugs:

* Catches the original bug without any help
* Catches an additional bug with 8-byte dictionaries
* Silently skip dictionaries less than 8 bytes, unless using `ZSTD_dct_fullDict`.
  This changes the compressor, which silently skips dictionaries <= 8 bytes.
* Allow repcodes that are equal to the dictionary content size, since it is in bounds.
Fix 2 bugs in dictionary loading
@Cyan4973
Cyan4973 merged commit 10f0e69 into master Nov 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

0