[go: up one dir, main page]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup installation supervisor unit tests #725

Merged
merged 1 commit into from
Sep 29, 2022
Merged

Cleanup installation supervisor unit tests #725

merged 1 commit into from
Sep 29, 2022

Conversation

gabrieljackson
Copy link
Contributor

Much of the code for the supervisor tests is repeated for each test. This change adds some helper functions to minimize repetition and to reduce the chance for error.

None

@gabrieljackson
Cleanup installation supervisor unit tests
66ae209 
Much of the code for the supervisor tests is repeated for each test.
This change adds some helper functions to reduce repitition and
to reduce the chance for error.
@gabrieljackson gabrieljackson added 2: Dev Review Requires review by a developer kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. labels Sep 28, 2022
@mm-cloud-bot mm-cloud-bot added release-note-none Denotes a PR that doesn't merit a release note. labels Sep 28, 2022
Szymongib
Szymongib approved these changes Sep 29, 2022
View reviewed changes
Copy link
Contributor
@Szymongib Szymongib left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice cleanup 👍

@gabrieljackson gabrieljackson added 4: Reviews Complete All reviewers have approved the pull request and removed 2: Dev Review Requires review by a developer labels Sep 29, 2022
@gabrieljackson gabrieljackson merged commit 244b993 into master Sep 29, 2022
@gabrieljackson gabrieljackson deleted the cleanup-supervisor-tests branch September 29, 2022 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Szymongib Szymongib Szymongib approved these changes

Assignees
No one assigned
Labels
4: Reviews Complete All reviewers have approved the pull request kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. release-note-none Denotes a PR that doesn't merit a release note.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gabrieljackson @Szymongib @mm-cloud-bot