Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
<
2CB7
span class="js-suggested-changes-inline-error-message position-relative error m-0" style="max-width:inherit">
WASAPI: fix memory leaks when getting device info
Base branch:
devSummary
This backports 3a7c48c ("WASAPI: Fix some memory leaks") from
dev-0.12, asdevstill has both leaks.ma_context_get_device_info_from_IAudioClient__wasapi()leaks in two places:IAudioClient::GetMixFormat()allocates the format, and the caller has to free it withCoTaskMemFree(). Nothing frees it.IPropertyStore::GetValue()returns the format in aPROPVARIANT, and the caller has to clear it.PropVariantClear()is only called when the device format isn't supported in exclusive mode, so it leaks when it is supported.