Repository navigation
Send signup confirmation links to the front end - #589
Open
daoudclarke wants to merge 4 commits into
Open
daoudclarke wants to merge 4 commits into
daoudclarke wants to merge 4 commits into
Conversation
allauth built the link from the request's host, so it pointed at api.mwmbl.org and its own HTML view. It now goes to FRONTEND_URL/account/confirm-email with the key and email, which the front end posts to /platform/confirm-email. No functional changes to the crawler. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01DTbu4oUPA9CSjTqUxmZgAv
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
They went to mwmbl.org, whose API can't check keys signed with the dev secret. No functional changes to the crawler. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01DTbu4oUPA9CSjTqUxmZgAv
No functional changes to the crawler.
The dev settings, which the tests inherit, now point FRONTEND_URL at the Vite dev server, so tests from main that hardcoded https://mwmbl.org failed. No functional changes to the crawler. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01DTbu4p7pvKRat7fTHWTNfJ
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
allauth builds the confirmation link from the request's host, so signup emails pointed at
api.mwmbl.organd allauth's own HTML view. A custom account adapter (mwmbl/account_adapter.py) now sends them to{FRONTEND_URL}/account/confirm-email?key=…&email=…, which posts to the existing/platform/confirm-emailendpoint, matching how email-change links already useFRONTEND_URL.Depends on mwmbl/front-end#109, which adds that page. Deploy it first.
Testing
make checkandmake testpass (1745 passed).Generated by Claude Code