Repository navigation
Check in with Sentry Crons from dump_index - #577
Merged
Merged
Conversation
Sentry already reports an exception the dump raises, through its default excepthook integration. It can't report a dump that was killed part-way or a cron that never ran. Check-ins on a `dump-index` monitor catch both, and a test keeps the monitor's schedule in step with app.json. No functional changes to the crawler. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01DTbu4oXHXewFWgSazZ9V88
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
dump_indexwraps the dump insentry_sdk.crons.monitor, using adump-indexmonitor. Sentry creates the monitor from the config on the first check-in.17 3 1 * *UTC, the same as thecronentry inapp.json.docs/index-dumps.mddescribes the monitor and says to keep the two schedules in step.Why
Sentry already reports an exception that
dump_indexraises, through the SDK's default excepthook integration. It can't report:Sentry Crons alerts on both: as a timeout, or as a missed check-in. This replaces the failure tracking that #538 would have added.
How it was verified
make checkpasses.test/test_index_dump.pypasses, 16 tests, 3 of them new:in_progressand thenok.error, and the exception still propagates.app.json.Generated by Claude Code