Repository navigation
Conversation
This will enable a best-effort version of min/max resends.
Codecov Report
@@ Coverage Diff @@
## master #3936 +/- ##
======================================
Coverage 56.7% 56.7%
======================================
Files 557 557
Lines 63511 63511
======================================
Hits 36058 36058
Misses 24264 24264
Partials 3189 3189
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
|
|
||
| // Buffer is a fixed-size buffer for servicing resends of min and max | ||
| // aggregations. | ||
| type Buffer interface { |
There was a problem hiding this comment.
is there a reason for the interface vs just a plain, public struct? since it has 0 dependencies/unlikely to have alternative interfaces, it would result in less indirection to pass *Buffer around, enable inlining of Buffer calls, and not break any clients if a new method is added.
There was a problem hiding this comment.
s/alternative interfaces/alternative implementations/
This adds a resend buffer with a bounded size, that will enable aggregator
resends of Min and Max aggregations. This will fill up the top bufferSize
elements, then replace it preferentially with better resend values if available.
What this PR does / why we need it:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing and/or backwards incompatible change?:
Does this PR require updating code package or user-facing documentation?: