8000 [release] also release in arm64 for darwin and linux by xjbhenry · Pull Request #4171 · m3db/m3 · GitHub
[go: up one dir, main page]

Skip to content

[release] also release in arm64 for darwin and linux - #4171

Open
xjbhenry wants to merge 1 commit into
m3db:masterfrom
xjbhenry:build-arm64
Open

xjbhenry wants to merge 1 commit into
m3db:masterfrom
xjbhenry:build-arm64

Conversation

@xjbhenry
@xjbhenry xjbhenry commented Dec 1, 2022 •
Copy link
Copy Markdown

What this PR does / why we need it:

Builds m3db in arm64 for darwin and linux. Since arm64 has been very popular recently, it makes sense to release m3db in arm64 as well.

Special notes for your reviewer:

Does this PR introduce a user-facing and/or backwards incompatible change?:

NONE

Does this PR require updating code package or user-facing documentation?:

NONE

@CLAassistant
CLAassistant commented Dec 1, 2022 •
Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

justinhwang added a commit that referenced this pull request Sep 24, 2026
…ges (#4442)

* [build] Release linux/darwin arm64 binaries and multi-arch docker images

Supersedes the stale #4171 and #4194.

goreleaser:
- Add arm64 to every build's goarch so releases ship
  {linux,darwin}_{amd64,arm64} tarballs.
- Move to goreleaser v2 (image v2.18.2, `version: 2`, `--clean` instead of
  the removed `--rm-dist`, `formats:` instead of the deprecated `format:`).
  The old v1.8.3 image bundles Go 1.18 and cannot build a go 1.26 module.

Docker:
- Build stage runs on $BUILDPLATFORM and cross-compiles with
  GOOS=$TARGETOS GOARCH=$TARGETARCH, so `docker buildx --platform
  linux/amd64,linux/arm64` produces native binaries for both without
  running the Go build under QEMU. Replaces the hardcoded
  `make <svc>-linux-amd64`.
- Align the m3coordinator release image with the others (alpine 3.20).

Makefile:
- Add LINUX_ARM64_ENV and <svc>/<tool>/services/tools-linux-arm64 targets
  mirroring the existing amd64 ones.

Submodule:
- Bump .ci to m3db/ci-scripts#113, which rewrites docker/build.sh to a
  single multi-arch `docker buildx build --push` per image.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

0