Repository navigation
etcd_docker 1: Refactor resources/docker package into resources/docke… - #4145
Merged
andrewmains12 merged 1 commit intoAug 31, 2022
Conversation
This was referenced Aug 29, 2022
andrewmains12
changed the base branch from
master
to
uber/20220816-grpc_update
August 29, 2022 22:03
andrewmains12
changed the base branch from
uber/20220816-grpc_update
to
master
August 30, 2022 14:43
andrewmains12
force-pushed
the
pr/andrewmains12/amains/grpc-update/etcd_tests.review/f922a2aa
branch
2 times, most recently
from
August 30, 2022 15:16
8d19f7d to
839899d
Compare
andrewmains12
changed the base branch from
master
to
uber/20220830-grpc_update
August 30, 2022 19:01
justinjc
reviewed
Aug 30, 2022
…rexternal, resources/dockerm3, x/dockertest PR 1 of etcd test refactor I am introducing a docker based etcd test framework. Overall structure I'm going for: resources/dockerm3 -- m3 docker containers resources/dockerexternal -- dependencies (prometheus, etcd) The reason I need this refactor: I'm going to pull the dockerexternal package into a bunch of internal tests. This introduces circular dependencies with the M3 resources, thus splitting out here. commit-id:f922a2aa
andrewmains12
force-pushed
the
pr/andrewmains12/amains/grpc-update/etcd_tests.review/f922a2aa
branch
from
August 30, 2022 21:28
839899d to
bdd86b8
Compare
justinjc
approved these changes
Aug 31, 2022
andrewmains12
deleted the
pr/andrewmains12/amains/grpc-update/etcd_tests.review/f922a2aa
branch
August 31, 2022 14:38
andrewmains12
added a commit
that referenced
this pull request
Oct 14, 2022
…rexternal, resources/dockerm3, x/dockertest (#4145) PR 1 of etcd test refactor I am introducing a docker based etcd test framework. Overall structure I'm going for: resources/dockerm3 -- m3 docker containers resources/dockerexternal -- dependencies (prometheus, etcd) The reason I need this refactor: I'm going to pull the dockerexternal package into a bunch of internal tests. This introduces circular dependencies with the M3 resources, thus splitting out here. commit-id:f922a2aa
saad-zaman
pushed a commit
that referenced
this pull request
Feb 28, 2023
…rexternal, resources/dockerm3, x/dockertest (#4145) PR 1 of etcd test refactor I am introducing a docker based etcd test framework. Overall structure I'm going for: resources/dockerm3 -- m3 docker containers resources/dockerexternal -- dependencies (prometheus, etcd) The reason I need this refactor: I'm going to pull the dockerexternal package into a bunch of internal tests. This introduces circular dependencies with the M3 resources, thus splitting out here. commit-id:f922a2aa
saad-zaman
pushed a commit
that referenced
this pull request
Mar 2, 2023
…rexternal, resources/dockerm3, x/dockertest (#4145) PR 1 of etcd test refactor I am introducing a docker based etcd test framework. Overall structure I'm going for: resources/dockerm3 -- m3 docker containers resources/dockerexternal -- dependencies (prometheus, etcd) The reason I need this refactor: I'm going to pull the dockerexternal package into a bunch of internal tests. This introduces circular dependencies with the M3 resources, thus splitting out here. commit-id:f922a2aa
andrewmains12
added a commit
that referenced
this pull request
Mar 24, 2023
…rexternal, resources/dockerm3, x/dockertest (#4145) PR 1 of etcd test refactor I am introducing a docker based etcd test framework. Overall structure I'm going for: resources/dockerm3 -- m3 docker containers resources/dockerexternal -- dependencies (prometheus, etcd) The reason I need this refactor: I'm going to pull the dockerexternal package into a bunch of internal tests. This introduces circular dependencies with the M3 resources, thus splitting out here. commit-id:f922a2aa
andrewmains12
added a commit
that referenced
this pull request
Mar 24, 2023
…rexternal, resources/dockerm3, x/dockertest (#4145) (#4153) PR 1 of etcd test refactor I am introducing a docker based etcd test framework. Overall structure I'm going for: resources/dockerm3 -- m3 docker containers resources/dockerexternal -- dependencies (prometheus, etcd) The reason I need this refactor: I'm going to pull the dockerexternal package into a bunch of internal tests. This introduces circular dependencies with the M3 resources, thus splitting out here. commit-id:f922a2aa
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…rexternal, resources/dockerm3, x/dockertest
PR 1 of etcd test refactor
I am introducing a docker based etcd test framework. Overall structure I'm going for:
resources/dockerm3 -- m3 docker containers
resources/dockerexternal -- dependencies (prometheus, etcd)
The reason I need this refactor: I'm going to pull the dockerexternal package into a bunch of internal tests. This introduces circular dependencies with the M3 resources, thus splitting out here.
commit-id:f922a2aa
Stack: