Make current directory evaluation in setup_viame.sh work outside of bash #116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Both |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I built VIAME but when I tried to
source setup_viame.shusingzshinstead ofbash, it failed because the$BASH_SOURCEvariable is empty. Runningbash setup_viame.shruns without error, but does not export the required variables into the calling shell../setup_viame.shfails at the substitution stage for the shell prompt.I replaced
$BASH_SOURCEwith the more generic$0, which has worked for me onbashandzsh. I've been usingzshon linux, which I don't think is super common, but it is now the default shell for MacOS starting with Catalina so it seems useful to support.