Repository navigation
add casrn/preferred_name to DSSTox - #8
Open
tfeiler-icf wants to merge 5 commits into
Open
tfeiler-icf wants to merge 5 commits into
tfeiler-icf wants to merge 5 commits into
Conversation
- adds model fields with indices - migration to pull existing data from content JSON - removes search generated field from DSSTox model and updates anyplace leveraging it. Can just search casrn/preferred_name now. - updates save method to add casrn/prefname population during standard dsstox import/save
tfeiler-icf
commented
Nov 2, 2026
tfeiler-icf
commented
Nov 2, 2026
tfeiler-icf
commented
Nov 2, 2026
caseyhans
reviewed
Nov 9, 2026
Contributor
There was a problem hiding this comment.
Okay great stuff, thanks for doing this! I left some feedback but I'm gonna make changes myself so no need to update anything yet. I wanna mess around with these queries... I had some performance concerns but turns out we only have like ~500 DSSTox objects so my concerns might be negligible here.
caseyhans
marked this pull request as ready for review
November 10, 2026 22:10
Contributor
|
Ok, ready for any final review/comments @tfeiler-icf @shanethacker |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DSSTox Model Updates
searchGeneratedField; generated via using SearchVector on dtxsid, content["preferredName"], and content["casrn"]preferred_nameandcasrnfields, populated from the existing content json field, originally fetched from dsstox databasesearchfield