Repository navigation
ci: lint browser bridge with ESLint - #4
Merged
Merged
Conversation
Tigon32
marked this pull request as ready for review
November 10, 2026 00:35
This was referenced Nov 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduce ESLint flat configuration focused on correctness, without changing runtime JavaScript or adding bundled dependencies. Add ESLint as a development-only package, run it after Node syntax checking in the existing required
rust-wasmCI job.Initial rules:
no-undef,no-dupe-args,no-duplicate-case,no-unreachable,no-unsafe-finally,no-invalid-regexp,no-fallthrough, andno-constant-condition. Legacy-style warnings are intentionally not enabled.Validation: Rust library tests, WASM library check, WASM release example, Node syntax check and ESLint passed on commit
a391c18c99d9a48168ba19c7505ea0ef06833597. Browser runtime behavior remains untested. Follow-up: commit a reproducible npm lockfile.Upstream cross-check and resolved defects
Searched open/closed issues and PRs on
not-fl3/miniquadforglDeleteQueries,GL_SHADER_BINARY_FORMATS,no-undef,fallthrough,queries,keyboard, and related terms. No direct upstream PR/issue fixing the two undefined references was identified. These references are present on upstreammaster.Fixed existing
js/gl.jsbugs: undefinederr(...)changed toconsole.error(...), and undefinedtexturesinglDeleteQueries(n, ids)changed toids. Combined duplicate switch cases in_webglGetand kept keyboard case groups with no behavior change; no ESLint suppressions introduced.Related but not equivalent upstream work: #698 (browser Cmd/key release; already integrated via fork PR #1), #587 (WASM loading refactor). Do not reimport them as fixes for this lint PR.