Removed incorrect assert #1164
Merged
Removed incorrect assert #1164
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomsons26
requested changes
Oct 28, 2024
There was a problem hiding this comment.
The gotos in this function need further looking into but out of scope of this pr i guess, looks like this should be:
if (upgrade == nullptr) {
break;
}
if (upgrade->Get_Type() == UPGRADE_TYPE_OBJECT
&& (Has_Upgrade(upgrade) || !Affected_By_Upgrade(upgrade))) {
break;
}
tomsons26
approved these changes
Oct 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the original code this branch leads to assert("WARNING: Script doCommandButton for button %s not implemented. Doing nothing"). This If exists to check if an AIteam member can doCommandButton (for example barracks building China radar), not Whether given command itself is valid. After change doCommandButton for button %s becomes implemented.
Fixes AI using America ControlRods, China Mines, China Radar and GLA CamoNetting (likely more) in skirmish.