Repository navigation
Conversation
|
This is awesome @TaKO8Ki! Great work, it may make sense to publish this into a package in the Biome's namespace in Wasmer so people can start trying it? Let me know if you need any help with that! |
|
@syrusakbary Thanks! After discussion with other maintainers, I will publish this into the namespace! |
| use std::{env, fs, io, path::PathBuf}; | ||
| // use std::{env, fs, io, path::PathBuf}; | ||
|
|
||
| use quote::{format_ident, quote}; | ||
| // use quote::{format_ident, quote}; |
There was a problem hiding this comment.
This file should not be affected by using wasix?
| @@ -22,42 +22,42 @@ pub(crate) fn start( | |||
| session: CliSession, | |||
| config_path: Option<PathBuf>, | |||
| ) -> Result<(), CliDiagnostic> { | |||
There was a problem hiding this comment.
We can probably un-do all changes on the daemon file, and just skip this option when compiling the cli to WASIX. Thoughts?
There was a problem hiding this comment.
I agree, and if that's possible, I think it would be the best approach.
|
Since it's necessary to change several dependency versions and sources for WASIX, the main challenge is how to integrate these changes into the main branch. |
|
Hey @TaKO8Ki I think it may make sense to have a secondary Cargo.toml only used for WASIX? (that includes the patch). Thoughts? |
|
@syrusakbary Thank you for the advice. I think that's one approach, but as far as I know, merging multiple Cargo.toml files is not possible. In that case, it seems we would end up managing Biome's dependencies that are not directly related to WASIX in duplicate. What I'm currently considering is simply creating a I'll work on it a bit more. |
Oh, I think what this strategy is actually much better than what I was proposing! Yup, makes sense |
|
If there is anything I can do to help, please let me know:) |
move jobs remove lsp implementations disable `run_server` use bininstall remove libc WASIX job use pull_request: fix remove a job stop using bininstall use moonrepo/setup-rust@v1 use bins revert changes in biome_wasm update Revert "update" This reverts commit 1ca031e. add `build-wasix` alias format format remove .node-version create wasix.rs
Summary
This is just a challenge. I have removed lsp deamon, libc dependency and so on for compiling Biome to WASIX. In detail, lsp implementation is deeply integrated with tokio and it seems difficult to resolve the issues quickly. I mean we need to add some changes to https://github.com/wasix-org/tokio and If the lsp implementation is unnecessary for WASIX, we can remove libc.
This is a messy way. If we compile Biome into WASIX in an original repository. I think we need to use conditional compilation.
Please check a GitHub Actions job for compiling Biome to WASIX here.
https://github.com/TaKO8Ki/biome/actions/runs/7009000801/job/19066556111?pr=1
Test Plan