[go: up one dir, main page]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for unusual_dm_activity_until field on member #9809

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add support for unusual_dm_activity_until field on member #9809

wants to merge 1 commit into from

Conversation

Soheab
Copy link
Contributor
@Soheab Soheab commented Apr 27, 2024

Summary

This is not documented but I have been seeing this field on the member payload for months now so not sure why it's not.

Checklist

  • If code changes were made then they have been tested.
    • I have updated the documentation to reflect the changes.
  • This PR fixes an issue.
  • This PR adds something new (e.g. new method or parameters).
  • This PR is a breaking change (e.g. methods or parameters removed/renamed)
  • This PR is not a code change (e.g. documentation, README, ...)

@Rapptz Rapptz added the pending PR implements an in-progress or explicitly unreleased Discord feature label May 5, 2024
Rapptz
Rapptz reviewed May 5, 2024
View reviewed changes
Copy link
Owner
@Rapptz Rapptz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm gonna hold off on this one until I get some confirmation (vague or not) of stability.

discord/member.py
@@ -1148,3 +1158,17 @@ def is_timed_out(self) -> bool:
if self.timed_out_until is not None:
return utils.utcnow() < self.timed_out_until
return False

def has_unusual_dm_activity(self) -> bool:
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't really like this method name, not a fan of has_ methods unless it's a last resort kind of thing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rapptz Rapptz Rapptz left review comments

Assignees
No one assigned
Labels
pending PR implements an in-progress or explicitly unreleased Discord feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Soheab @Rapptz