added check for new user join to chat_endpoint #993
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0b36dfb
to
527b901
Compare
zzstoatzz
approved these changes
Nov 16, 2024
| await slack_webhook.notify( | ||
| body=f"Attempted to respond in DM channel: {channel_name}", | ||
| subject="Slackbot DM Warning", | ||
| print(payload.event) |
There was a problem hiding this comment.
let's change this to an assert so that our type checker knows for sure that payload.event is not equal to None
Suggested change
| print(payload.event) | |
| assert payload.event is not None, "No event found!" |
Comment on lines
+163
to
170
| message = message_var["text"] | ||
| # format the message with the user's id | ||
| f_string = message.format(user_id=user_id) | ||
| # post the message to the user's DM channel | ||
| await task(post_slack_message)( | ||
| message=(f_string), | ||
| channel_id=user_id, # type: ignore | ||
| ) |
There was a problem hiding this comment.
nit on variable names and avoid shadowing the message kwarg for post_slack_message
Suggested change
| message = message_var["text"] | |
| # format the message with the user's id | |
| f_string = message.format(user_id=user_id) | |
| # post the message to the user's DM channel | |
| await task(post_slack_message)( | |
| message=(f_string), | |
| channel_id=user_id, # type: ignore | |
| ) | |
| message_template = message_var["text"] | |
| # format the message with the user's id | |
| rendered_message = message_template.format(user_id=user_id) | |
| # post the message to the user's DM channel | |
| await task(post_slack_message)( | |
| message=rendered_message, | |
| channel_id=user_id, # type: ignore | |
| ) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added marvin welcome message to chat_endpoint.
In order to get the message, you'll need to create a Prefect Cloud variable called "marvin_welcome_message" that has the following json obj:
You'll also need to ensure the Slack chatbot is subscribed to the following bot events to check for new users joining the workspace :
^This can be modified on the "Event Subscriptions" page when configuring your app in Slack