-
-
Notifications
You must be signed in to change notification settings - Fork 149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: Rework of the Presence reference page #1062
base: monorepo
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These are some of the things i wish to improve, feel free to suggest others!
apps/docs/reference/presence.md
Outdated
The [`Presence`](#presence) class represents a client, which can be used to interact with the PreMiD extension. | ||
|
||
### Example | ||
|
||
```javascript | ||
It also provides lifecycle events via [`UpdateData`](#update_data) and [`iFrameData`](#iframe_data). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I spent some time trying to better explain what the Presence class does, from my understanding it is like an SDK to communicate with the PreMiD extension, with extra utilites for translations and DOM access.
maybe can be explained differently idk
## constructor(options: [`PresenceOptions`](#presence-options)) {#constructor} | ||
|
||
|
||
## setActivity(data: [`PresenceData`](#presence-data) | [`Slideshow`](#slideshow)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i've thought maybe we should add an example with DOM stuff, but maybe it's better to leave it to the Guide section instead
This PR is a WIP that aims to improve the docs' Presence reference page
There's some methods still missing, however i wanted to share what i've done so far.
any kind of feedback would be very appreciated!
preview deployment: https://docs.pmd.eudrino.crun.zip/reference/presence.html