[go: up one dir, main page]

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Rework of the Presence reference page #1062

Draft
wants to merge 10 commits into
base: monorepo
Choose a base branch
from

Conversation

itsmeeudrino
Copy link
@itsmeeudrino itsmeeudrino commented Jul 28, 2024

This PR is a WIP that aims to improve the docs' Presence reference page

There's some methods still missing, however i wanted to share what i've done so far.

any kind of feedback would be very appreciated!

preview deployment: https://docs.pmd.eudrino.crun.zip/reference/presence.html

Copy link
Author
@itsmeeudrino itsmeeudrino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are some of the things i wish to improve, feel free to suggest others!

Comment on lines 8 to 11
The [`Presence`](#presence) class represents a client, which can be used to interact with the PreMiD extension.

### Example

```javascript
It also provides lifecycle events via [`UpdateData`](#update_data) and [`iFrameData`](#iframe_data).
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I spent some time trying to better explain what the Presence class does, from my understanding it is like an SDK to communicate with the PreMiD extension, with extra utilites for translations and DOM access.

maybe can be explained differently idk

## constructor(options: [`PresenceOptions`](#presence-options)) {#constructor}


## setActivity(data: [`PresenceData`](#presence-data) | [`Slideshow`](#slideshow))
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i've thought maybe we should add an example with DOM stuff, but maybe it's better to leave it to the Guide section instead

apps/docs/reference/presence.md Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant