8000 Delete unused code from com.aapeli package by StenAL · Pull Request #105 · PhilippvK/playforia-minigolf · GitHub
[go: up one dir, main page]

Skip to content

Delete unused code from com.aapeli package - #105

Merged
PhilippvK merged 1 commit into
PhilippvK:masterfrom
StenAL:remove-dead-code
Mar 26, 2024
Merged

PhilippvK merged 1 commit into
PhilippvK:masterfrom
StenAL:remove-dead-code

Conversation

@StenAL
@StenAL StenAL commented Jan 5, 2024
Copy link
Copy Markdown

This deletes ~7400 lines of unused code, making the project easier to reason about and develop. Almost all of these classes are never referenced in code accessible by the minigolf client, with two exceptions:

  • Product is referenced in AApplet.java in some methods that are never called; these methods were also removed
  • AutoPopups.java references Class85, however the field storing an instance is never initialized so it's always null. This field was removed.

This deletes ~7400 lines of unused code, making the project easier to
reason about and develop. Almost all of these classes are never
referenced in code accessible by the minigolf client, with two
exceptions:
- Product is referenced in AApplet.java in some methods that are never
called; these methods were also removed
- AutoPopups.java references Class85, however the field storing an
instance is never initialized so it's always null. This field was
removed.
@PhilippvK
PhilippvK merged commit 392c17d into PhilippvK:master Mar 26, 2024
@StenAL
StenAL deleted the remove-dead-code branch March 27, 2024 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

0