Repository navigation
Fix sound, upgrade to Java 17 - #103
Conversation
This makes it possible to run tests on Windows, otherwise files were getting copied to a path using "\" but tests were looking for paths with "/".
|
@StenAL This is awesome. Give me a few days to try it out :) |
|
@StenAL Sound works as expected! However I found out that the game crashes at the end of a singleplayer round: This does not happen in the |
|
Thanks for the thorough testing! I only tested in multiplayer. I've pushed a fix now, the issue was with trying to play music at the end of a game based on the results, but in a single player game the server does not send any results so there was a null dereference. |
|
That was crazy fast! I will approve and probably merge in a few hours unless you have anything against that. |
|
@StenAL the CI needs a patch to use Java 17 instead of 8. Should I fix this in a followup or can you have a look? |
|
I can take a look and I'll also squash the crash fix commit into the original change. |
|
@PhilippvK Looks like you need to approve every CI run, let's hope the first try works. |
Java 17 is the latest LTS version of Java and comes with convenience APIs and performance improvements. Changes to get it working: - the Launch4j Maven plugin had to be upgraded. The new version has JRE path as a required option. Setting it to "jre" preserves the previous behavior of using the host's bundled JRE is preserved. - a dependency of appbundle-maven-plugin had to be upgraded - the Netty dependency could be removed, it was completely unused
This is in preparation of getting sound to work. No functional changes intended.
No functional changes intended. Code changes except for renaming things: - remove hardcoded static strings - remove unnecessary escapes from debug log strings
No functional changes intended. Code changes except for renaming things: - combine AApplet and Applet fields - make `loadSoundClipsOnRegister` and `debug` fields final - add generic types to Hashtables
Turns out this code is completely unused, however now that it's cleaned up it can potentially be used in the future to add more sounds to the game. No functional changes intended. Code changes except for renaming things: - remove unused soundplayer field from ClipPlaybackTask - remove hardcoded static strings - make some fields that do not change final
This makes SoundManager actually find the audio clips, previously it failed silently. The only code playing audio at the moment is a notification sound to a lobby host whenever someone joins their lobby, however further commits will expand on audio functionality.
Works both in single player and multiplayer for other players' strokes.
No functional changes. This is in preparation of playing win/lose sounds at the end of a multiplayer game.
This is used for displaying a "Winner" or "Draw" string next to player names at the end of the game.
This contains the exact same files as the assets directory
Also remove the unused MANIFEST.MF file. A jar manifest is automatically generated by Maven.
|
Alright, looks like CI passed (https://github.com/PhilippvK/playforia-minigolf/actions/runs/4834120524/jobs/8614993225?pr=103). I've squashed the two fixup commits, the crash fix is now in d7cdeb8 and CI fix is in dc8b995 I'm ready for merging now. |
This restores the satisfying
thunksound that plays on every stroke.See individual commits for more details.
Highlights: