8000 add --norandom to client to disable shot randomization by thewavelength · Pull Request #100 · PhilippvK/playforia-minigolf · GitHub
[go: up one dir, main page]
Skip to content

add --norandom to client to disable shot randomization - #100

Merged
PhilippvK merged 1 commit into
PhilippvK:masterfrom
thewavelength:master
Mar 6, 2022
Merged

add --norandom to client to disable shot randomization#100
PhilippvK merged 1 commit into
PhilippvK:masterfrom
thewavelength:master

Conversation

@thewavelength
@thewavelength thewavelength commented Mar 5, 2022
Copy link
Copy Markdown

This change allows the client to pass -n (--norandom) to the launcher to disable any shot randomization.
In our group of players we consider this "pro mode" as luck is being removed from the equation.

@thewavelength
add --norandom to client to disable shot randomization
38eef4b 
This change allows the client to pass -n (--norandom) to the launcher to disable any shot randomization.
In our group of players we consider this "pro mode" as luck is being removed from the equation.
@PhilippvK
PhilippvK requested review from PhilippvK and pehala March 6, 2022 03:09
@PhilippvK PhilippvK self-assigned this Mar 6, 2022
@PhilippvK
PhilippvK commented Mar 6, 2022
Copy link
Copy Markdown
Owner

@thewavelength Thank you for your contribution.
I gave it a try and it looks fine. I really don't like that this stuff (like aimbot etc.) is managed on the client-side, but that's how the game was designed...

On the long term I would strive for the following:

  • Use a config file for such settings instead of command line flags
  • communicate these options with the server to detect which features are enabled on the client

However both points are out of scope for the near future.

@PhilippvK
PhilippvK commented Mar 6, 2022 •
edited
Loading
Copy link
Copy Markdown
Owner

I will likely merge this in the next few days unless @pehala has something against it.

@thewavelength
thewavelength commented Mar 6, 2022
Copy link
Copy Markdown
Author

I also had a quick look in the source and maybe it can be hacked into the basicinfo message which comes from the server.

@PhilippvK
PhilippvK merged commit 1dc921b into PhilippvK:master Mar 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pehala pehala pehala approved these changes
@PhilippvK PhilippvK Awaiting requested review from PhilippvK

Assignees

@PhilippvK PhilippvK

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@thewavelength @PhilippvK @pehala
0