8000 Add Dockerfile for server docker image by pehala · Pull Request #60 · PhilippvK/playforia-minigolf · GitHub
[go: up one dir, main page]
Skip to content

Add Dockerfile for server docker image - #60

Merged
PhilippvK merged 1 commit into
PhilippvK:masterfrom
pehala:server_docker
Oct 4, 2020
Merged

Add Dockerfile for server docker image#60
PhilippvK merged 1 commit into
PhilippvK:masterfrom
pehala:server_docker

Conversation

@pehala
@pehala pehala commented Oct 4, 2020 •
edited
Loading
Copy link
Copy Markdown
Collaborator
  • Add Dockerfile to create container image for server.
    • It uses two-phase build where the first phase run mavens and second phase only runs the compiled jar.
    • I didn't add editor and client to the server because docker is not ideal for starting GUI applications, I can add them if you want them but I am not even sure if they will run on macOS (for Linux you basically have to use magic to forward all the x11 stuff).
  • It has bundled tracks.

I didn't include actions yet, the reason is I would like to know which repository you would like the image to reside in.

@pehala
pehala requested a review from PhilippvK October 4, 2020 16:22
@PhilippvK
PhilippvK commented Oct 4, 2020
Copy link
Copy Markdown
Owner

I didn't add editor and client to the server because docker is not ideal for starting GUI applications

I experimented with UI-Forwarding in Docker earlier this year on Windows/Linux/MacOS and got it working everywhere, but it‘s far away from intuitive. The effort (installing additional Software and configure it) is to high to be useful.

@PhilippvK
PhilippvK commented Oct 4, 2020
Copy link
Copy Markdown
Owner

Just FYI: I also tried out a software called XPRA (running inside Docker) which allows to run X11-based applications in a web browser. In my option, it‘s not reliable and easy enough to use. (My intention when trying it out was to figuring out if it’s possible to develop 100% in a cloud-based IDE (GitHub Codespaces)

@PhilippvK
PhilippvK merged commit f33a4e0 into PhilippvK:master Oct 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@PhilippvK PhilippvK PhilippvK approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@pehala @PhilippvK
0