8000 Add tests + small improvements to the CLI parsing by pehala · Pull Request #50 · PhilippvK/playforia-minigolf · GitHub
[go: up one dir, main page]
Skip to content

Add tests + small improvements to the CLI parsing - #50

Merged
PhilippvK merged 3 commits into
PhilippvK:masterfrom
pehala:tests
Sep 6, 2020
Merged

Add tests + small improvements to the CLI parsing#50
PhilippvK merged 3 commits into
PhilippvK:masterfrom
pehala:tests

Conversation

@pehala
@pehala pehala commented Sep 6, 2020
Copy link
Copy Markdown
Collaborator
  • Small improvements to the CLI parsing.
    • Version is now read from MANIFEST files.
    • Make language selection case insensitive.
  • Change Launcher classes to support test.
    • Extracting some calls into separate methods so they can be mocked
    • Make few methods and properties public so they can be tested.
      • If we had project written in a better way this would not be needed, but we are no there yet.
  • Add tests
    • Using Mockito and JUnit 5.
    • Tests are automatically run on mvn install, so no changes to CI needed.
    • Currently only contains CLI tests + Icon loading test.

I am not sure how much are you familiar with JUnit 5 or testing in general, so if you didn't understand something or wanted something explained, just let me know. Same if you would like to see more test cases.

@pehala
Remove res as a resource folder from .iml files
b297ab0
@pehala
Small improvements to the CLI
43ec325 
* Read version from MANIFEST file
* Add entries to all MANIFEST files
* Make language selection case insensitive
* Prepare Launcher classes for tests
@pehala pehala added the enhancement New feature or request label Sep 6, 2020
@pehala
pehala requested a review from PhilippvK September 6, 2020 10:35
@pehala pehala changed the title Add tests + small improvements to the CLI parsing [WIP] Add tests + small improvements to the CLI parsing Sep 6, 2020
@pehala
Add basic tests
f60348f 
* Currently tests only CLI + icon loading.
@pehala pehala changed the title [WIP] Add tests + small improvements to the CLI parsing Add tests + small improvements to the CLI parsing Sep 6, 2020
@PhilippvK
PhilippvK commented Sep 6, 2020
Copy link
Copy Markdown
Owner

Works great for me.

@PhilippvK
PhilippvK merged commit 4e0e8c9 into PhilippvK:master Sep 6, 2020
@pehala pehala mentioned this pull request Sep 6, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@PhilippvK PhilippvK Awaiting requested review from PhilippvK

Assignees

No one assigned

Labels

enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@pehala @PhilippvK
0