8000 Cleanup and reorganize code by pehala · Pull Request #44 · PhilippvK/playforia-minigolf · GitHub
[go: up one dir, main page]

Skip to content

Cleanup and reorganize code - #44

Merged
PhilippvK merged 2 commits into
PhilippvK:masterfrom
pehala:reorganize
Sep 3, 2020
Merged

PhilippvK merged 2 commits into
PhilippvK:masterfrom
pehala:reorganize

Conversation

@pehala
@pehala pehala commented Sep 3, 2020 •
Copy link
Copy Markdown
Collaborator
  • Reorganize code
    • Move code into src/main/java
    • Move resources into src/main/resources
  • Reorganize folders inside client resources.
  • Remove legacy code and resources.
    • Only thing that was left is the assets directory, @PhilippvK do you want to remove it as well?
    • Removed AGolf2 and playray packages as they were not being used.
  • Rewrite ImageManager class.
    • Add names to many attributes, clean up unused attributes, rewrite some methods etc.
    • This should make it much more readable and simple.

Note: This is very experimental, I tested that it compiles and runs through exec and from jars but I didn't really play for long with it.

* Resources are now in src/main/resources
  * Instead of agolf/picture the directory is now picture/agolf
* Code is now in src/main/java
* Rewrite ImageManager
  * Update to load from new resouce directories
  * Cleanup of the class, rename a few arguments and methods
@PhilippvK
Copy link
Copy Markdown
Owner

−50,805 Lines of code. 🤣

Can't wait to try this out! Would you recommend to merge #40 before?

@pehala
pehala commented Sep 3, 2020
Copy link
Copy Markdown
Collaborator Author

Nope, it will be better to do this and I will then rebase and resolve all conflict that will be in the #40

@PhilippvK
Copy link
Copy Markdown
Owner

We may remove the assets directory in a later commit. This can be merged now.

@PhilippvK
PhilippvK merged commit 36eb436 into PhilippvK:master Sep 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

0