[go: up one dir, main page]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Error message for missing IDs, with line numbers. #467

Merged
merged 3 commits into from
Sep 17, 2020
Merged

Error message for missing IDs, with line numbers. #467

merged 3 commits into from
Sep 17, 2020

Conversation

dilpath
Copy link
Member
@dilpath dilpath commented Sep 17, 2020

dweindl
dweindl approved these changes Sep 17, 2020
View reviewed changes
petab/lint.py Outdated Show resolved Hide resolved
petab/lint.py Outdated Show resolved Hide resolved
petab/lint.py Show resolved Hide resolved
@codecov
Copy link
codecov bot commented Sep 17, 2020 •
edited
Loading

Codecov Report

Merging #467 into develop will decrease coverage by 0.07%.
The diff coverage is 66.66%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #467      +/-   ##
===========================================
- Coverage    78.02%   77.95%   -0.08%     
===========================================
  Files           22       22              
  Lines         2253     2254       +1     
  Branches       539      540       +1     
===========================================
- Hits          1758     1757       -1     
- Misses         365      366       +1     
- Partials       130      131       +1
Impacted Files Coverage Δ
petab/lint.py 77.19% <66.66%> (-0.58%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 90b6176...5ffb047. Read the comment docs.

@sonarcloud
Copy link
sonarcloud bot commented Sep 17, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@dilpath dilpath merged commit e1bd866 into develop Sep 17, 2020
@dilpath dilpath deleted the fix_466 branch September 17, 2020 21:46
@dilpath dilpath linked an issue Sep 17, 2020 that may be closed by this pull request
Delimiter issues in empty lines: tab-only line produces regex error with petablint #466
Closed
dweindl added a commit that referenced this pull request Sep 21, 2020
@dweindl
Merge pull request #468 from PEtab-dev/release_0.1.9
826e7f7 
Release 0.1.9

Library:

* Allow URL as filenames for YAML files and SBML models (Closes #187) (#459)
* Allow model time in observable formulas (#445)
* Make float parsing from CSV round-trip (#444)
* Validator: Error message for missing IDs, with line numbers. (#467)
* Validator: Detect duplicated observable IDs (#446)
* Some documentation and CI fixes / updates
* Visualization: Add option to save visualization specification (#457)
* Visualization: Column XValue not mandatory anymore (#429)
* Visualization: Add sorting of indices of dataframes for the correct sorting
  of x-values (#430)
* Visualization: Default value for the column x_label in vis_spec (#431)
@dilpath dilpath mentioned this pull request Oct 21, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dweindl dweindl dweindl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Delimiter issues in empty lines: tab-only line produces regex error with petablint
2 participants
@dilpath @dweindl