[go: up one dir, main page]

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Lua] Make Ix'Aern (Monk) and adds (Qn'aern) more retail accurate #6420

Open
wants to merge 1 commit into
base: base
Choose a base branch
from

Conversation

TracentEden2
Copy link
Contributor
@TracentEden2 TracentEden2 commented Nov 8, 2024

I affirm:

  • I understand that if I do not agree to the following points by completing the checkboxes my PR will be ignored.
  • I understand I should leave resolving conversations to the LandSandBoat team so that reviewers won't miss what was said.
  • I have read and understood the Contributing Guide and the Code of Conduct.
  • I have tested my code and the things my code has changed since the last commit in the PR and will test after any later commits.

What does this pull request do?

This PR makes Ix'Aern (Monk) and adds (Qn'aern RDM and WHM) more retail accurate via the following changes:

  1. Adjusts HPs, status immunities, and levels of Ix'Aern and adds
  2. Adjust bracer mode logic to start when any of Ix'Aern or adds goes below 60% HP
  3. Remove dependence between adds using 2hrs and bracer mode
  4. Delay adding braclets animation to Ix'Aern (Monk) until after hundred fists
  5. Change bracer mode delay reduction to apply to both Ix'Aern and adds and use the DELAY mod (as HASTE_ABILITY is capped and not really for use by mobs), also note the delay is a true delay reduction (that impacts TP gain and TP imparted) as validated by retail testing and thus DELAY is appropriate.

These changes are based on retail captures of Ix'Aern by Siknoz here and here.

Steps to test these changes

Fight Ix'Aern (Monk) and adds and compare to retail captures

@WinterSolstice8
Copy link
Member

haste_ability is still applied there is a separate mod only for 2H that's additive a few lines down
reducing delay also reduces TP gain/TP given being hit, though I can't really tell from the cap (too many mobs at once) if the delay is actually being reduced, but I haven't seen an instance where that is the case (to memory, at least)

@WinterSolstice8
Copy link
Member

Though that said, applying haste would reduce recast timers for spells, though in the real world you're going to kill the adds before you actually fight the NM. Maybe we need a separate mod to just reduce auto attack delay only that doesn't modify TP gain or recasts in any way

@TracentEden2
Copy link
Contributor Author
TracentEden2 commented Nov 8, 2024

haste_ability is still applied there is a separate mod only for 2H that's additive a few lines down
reducing delay also reduces TP gain/TP given being hit, though I can't really tell from the cap (too many mobs at once) if the delay is actually being reduced, but I haven't seen an instance where that is the case (to memory, at least)

Ah yeah true, I am not sure then.

@TracentEden2
Copy link
Contributor Author

haste_ability is still applied there is a separate mod only for 2H that's additive a few lines down reducing delay also reduces TP gain/TP given being hit, though I can't really tell from the cap (too many mobs at once) if the delay is actually being reduced, but I haven't seen an instance where that is the case (to memory, at least)

You can find caps of just the NM (1 organ popping) here and here, maybe possible to check for delay reduction from those?

@TracentEden2
Copy link
Contributor Author

haste_ability is still applied there is a separate mod only for 2H that's additive a few lines down reducing delay also reduces TP gain/TP given being hit, though I can't really tell from the cap (too many mobs at once) if the delay is actually being reduced, but I haven't seen an instance where that is the case (to memory, at least)

You can find caps of just the NM (1 organ popping) here and here, maybe possible to check for delay reduction from those?

For completeness I did an additional cap to check this and without bracers I was getting 12 TP per hit and with bracers I was getting 10 TP per hit, so seems it is an actual delay reduction. I also verified with Jimmayus and he said that he knows of cases where it is a delay reduction, so pretty interesting.

@TracentEden2 TracentEden2 marked this pull request as ready for review November 11, 2024 21:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants