Better export to epub #1144
Better export to epub #1144
Conversation
|
Why should we export reader ui to epub? |
package.json
Outdated
| "@cd-z/epub-constructor": "^3.0.1", | ||
| "@cd-z/react-native-epub-creator": "^3.0.0", |
There was a problem hiding this comment.
I fucked up the dependency so i had to create another version and installed it manually to make sure it works, however it can be removed again since it lt's not neccessary.
| @@ -51,6 +53,7 @@ | |||
| "react-native-device-info": "^8.4.7", | |||
| "react-native-drawer-layout": "^3.2.2", | |||
| "react-native-error-boundary": "^1.1.16", | |||
| "react-native-file-access": "^3.1.0", | |||
There was a problem hiding this comment.
It belongs to my package as dependency, however if you don't install it manually, for some reason it says the package is not linked and can't be used. Which means the export feature is broken.
| const jsFilePath = path.resolve( | ||
| __dirname + '/../android/app/src/main/assets/css/', | ||
| 'index.js', | ||
| ); |
There was a problem hiding this comment.
If this file is created in building time only, it should be ignore from git.
| @@ -1,6 +1,6 @@ | |||
| import React, { useState } from 'react'; | |||
| import { StyleSheet, View } from 'react-native'; | |||
| import { Modal, TextInput, Text } from 'react-native-paper'; | |||
| import { Modal, TextInput, Text } from 'react-native-paper'; //@ts-ignore | |||
There was a problem hiding this comment.
| import { Modal, TextInput, Text } from 'react-native-paper'; //@ts-ignore | |
| import { Modal, TextInput, Text } from 'react-native-paper'; |
| //@ts-ignore | ||
| import css from '../../../../../android/app/src/main/assets/css/index'; |
There was a problem hiding this comment.
for static files, you should import by using require to avoiding TS warning
Where do I export the reader ui? |
` + (css as string).replace(/chapter/g, '#chapter') |
|
Btw, you could use implemented |
28aea06
to
8c2f8e6
Compare
This comment was marked as outdated.
This comment was marked as outdated.
|
Feature request: |
Not planed, since only a minority of users will open the epub |
|
F-r It would be nice to know. Not necessary tho. |
|
Performance issue: beta(2:25): YouCut_20240728_001100235.mp4Stable(1:10): YouCut_20240728_000134690.mp4Detail: i tested on a beta build that doesnt have the changes of this pr..Commit 7cf8692. It's as fast as stable. I assume this pr modifications are the cause. |
|
Bug -Novelfull 1.0.0, Cultivation chat group, chapter 841 Solution: override or/and make a window appear that says that these chapter failed for some reason |
|
Export error: It comes from an imported EPUB entry. |
I finally found the time to work a bit on the library and implemented it in LNReader with a few changes for better compatibility.
This PR closes: