-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LLNL/mfem #21
Comments
I just saw this, thank you. Here are some comments on the outstanding TODO items. Please let me know what you think. Todo
Done
MFEM is a library, and its version is available to apps that include it. You can also see it with
This is now available at https://docs.mfem.org/, see https://mfem.org/download/.
This is listed here: https://github.com/mfem/mfem/blob/master/CONTRIBUTING.md#contact-information
This is mentioned here: https://github.com/mfem/mfem/blob/master/CONTRIBUTING.md#developer-guidelines
We do that: https://github.com/mfem/mfem/runs/6178104680?check_suite_focus=true#step:4:6
We have a link to https://mfem.org/examples. It is tricky to provide a simple example for MFEM usage, because even the simplest code https://github.com/mfem/mfem/blob/master/examples/ex0.cpp requires some domain knowledge. |
Signed-off-by: vsoch <vsoch@users.noreply.github.com>
Thank you @tzanio ! I've been quietly doing this (in preparation for some future effort), and I've updated the mfem page to your specifications, and it's rendered here: https://vsoch.github.io/contributor-ci-llnl/cfa/cfa-mfem-mfem/#/cfa/. mfem has a very good score overall - out of all the repos only spack is a bit higher (e.g., 81% to 89%). Since it's a development library, what would you have in mind for a container? if it builds with spack, I could probably throw together a quick container base and instructions that would allow for development. Is there a dummy example we could include alongside it for an interested party? |
Thanks @vsoch. I'll report here if/when we make further improvements. |
The simplest thing will be to have a build (with Spack) including all examples and miniapps (we have many of these). A more ambitious option is to also enable the support for some of our optional TPLs, e.g. |
Nice job!
https://github.com/vsoch/contributor-ci-llnl/blob/main/_cfa/cfa-mfem-mfem.md
The text was updated successfully, but these errors were encountered: