[go: up one dir, main page]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes when building against #3

Merged
merged 3 commits into from
May 10, 2017
Merged

Fixes when building against #3

merged 3 commits into from
May 10, 2017

Conversation

mplegendre
Copy link
Member
  • Build fixes for when building against glibc.
  • Warning cleanup
  • Move default to be against glibc (for now)

@mplegendre mplegendre mentioned this pull request May 10, 2017
Closed
DavidPoliakoff
DavidPoliakoff approved these changes May 10, 2017
View reviewed changes
src/libc_wrappers.h
#define gotcha_close(A) close(A)
#define gotcha_mprotect(A, B, C) mprotect(A, B, C)
#define gotcha_read(A, B, C) read(A, B, C)
#define gotcha_malloc malloc
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Neat, that's a clever solution

@DavidPoliakoff
Copy link
Contributor

Thanks, looks good to me

@DavidPoliakoff DavidPoliakoff merged commit c6534bb into LLNL:master May 10, 2017
@twang15 twang15 mentioned this pull request Jul 3, 2017
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DavidPoliakoff DavidPoliakoff DavidPoliakoff approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mplegendre @DavidPoliakoff