Repository navigation
Conversation
GLSL_EXT_shader_invocation_reorder and GLSL_NV_shader_invocation_reorder said the motion functions were allowed only when GLSL_NV_ray_tracing_motion_blur was "present", and did not gate the current time or vertex position functions at all. State that these functions are available only if the interacting extension is also enabled, and list all of them in the interactions sections. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
Author
Contributor
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to KhronosGroup/SPIRV-Registry#462 and KhronosGroup/glslang#4503.
GLSL_EXT_shader_invocation_reorderandGLSL_NV_shader_invocation_reordersaid the motion functions were "allowed only when GLSL_NV_ray_tracing_motion_blur extension is present", which doesn't say whether that extension has to be enabled in the shader. The current time and vertex position functions were not gated on their interacting extensions at all, even though they needSPV_NV_ray_tracing_motion_blur/SPV_KHR_ray_tracing_position_fetchin SPIR-V (see SPIRV-Registry#463 and glslang#4503).This change states that these functions are available only if the interacting extension is also enabled:
GL_NV_ray_tracing_motion_blur:hitObjectTraceRayMotionEXT,hitObjectRecordMissMotionEXT,hitObjectTraceMotionReorderExecuteEXT,hitObjectGetCurrentTimeEXT, and the NV equivalents (hitObjectTraceRayMotionNV,hitObjectRecordHitMotionNV,hitObjectRecordHitWithIndexMotionNV,hitObjectRecordMissMotionNV,hitObjectGetCurrentTimeNV).GL_EXT_ray_tracing_position_fetch:hitObjectGetIntersectionTriangleVertexPositionsEXT.The interactions sections now list every affected function, and the EXT spec gains a dependency on and an interactions section for
GLSL_EXT_ray_tracing_position_fetch. The NV spec gains an interactions section forGLSL_NV_ray_tracing_motion_blur.Discussed and agreed at the Vulkan Ray Tracing TSG. The matching glslang enforcement is in KhronosGroup/glslang#4517. The SER tests in the Vulkan CTS already enable the interacting extensions, so no CTS changes are needed.
▎ GenAI disclosure: Draft assisted by Claude (claude-opus-5-5, Anthropic, commercial SaaS — Claude Code CLI).