Repository navigation
test(web): update stale browser assertions to the current design - #13
Merged
Merged
Conversation
Several browser scripts still asserted behaviour that changed on purpose: the 0.3.0 neutral palette colours, the overview tabs and #period removed in 0.5.0, per-page filter storage, demo weekly estimates that are now amounts, and the App layout showing the sync button only on the home screen. The assertions now check the current contract, and checks for removed features are dropped or moved to the view that replaced them. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Five browser scripts failed on
mainfor reasons unrelated to any bug. They asserted behaviour that had changed on purpose in earlier releases, so the suite could not be used as a merge check.Result
Only
tests/changes.appearance-sortingandmobile-appexpect the colours of the 0.3.0 neutral palette (--canvas#0f0f11 in dark,--line#e4e4e7 for the drawer border) instead of the pre-redesign values.mobile-appandvisual-feedbackexpect the demo ledger's weekly estimates as real amounts, computed from the demo data and required to be dollar amounts, instead of N/A.visual-feedbackdrops checks for the overview tabs,#period,.metricsand the old mobile trend strip, which no longer exist. The trend painted-pixel check, chart style persistence and filter bar checks move to the merged overview. It also checks the current-page accent colour in the navigation.report-preferencesfollows the per-page filter storage (meterleaf-report-filter-<page>) thatdocs/reporting.mddescribes. It checks that reports keep their own range, model and account across reloads, that the ledger and overview do not inherit them, and that the USD basis stays shared.sync-refreshchecks that the App layout hides the sync button outside the home screen, then opens it from the home screen.Verification
Run sequentially against a demo backend, a non-demo Vite build and an isolated headless Chrome, each script in a fresh tab. All nine pass:
browser.smoke,account-management,mobile-app,visual-feedback,appearance-sorting,report-preferences,sync-refresh,quota-pwa-layout,global-layout.bun run typecheckandbun test tests(337 pass) also pass.🤖 Generated with Claude Code