Repository navigation
feat(web): manage accounts from the overview and drop the accounts page - #11
Merged
Merged
Conversation
The overview's account section already showed the same rows as the standalone 账户额度 page, so the page is removed. Sorting, renaming, archiving, restoring and deleting now happen in the overview's account section on web and on the mobile home, with an 已归档 N entry for the archived list. Moving an account skips archived neighbours. The legacy #accounts and #period hash handling is removed. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
After #9 merged the overview, its 账户额度 section showed the same account rows as the standalone 账户额度 page. The page only remained for account management (sort, rename, archive, delete, archived list) and an account filter that has little use with a handful of accounts.
Result
#accountsand#periodhashes is removed. Those links now open the last visited page. Thepagepreference no longer accepts them, and theaccount-archive-viewandaccount-filterpreferences are dropped.Verification
bun run typecheck,bun test tests(337 pass, including a new ordering test for archived neighbours) andbun run buildpass.tests/browser.smoke.tspasses at 1440×1000 and 390×844.tests/account-management.browser.tspasses and covers sorting persistence, sort skipping archived accounts, archive and restore, the transient archived view, rename, delete, failed writes and read-only states.tests/mobile-app.browser.tspasses its new mobile account-management checks (archive, restore, single empty state, sort persistence) and then stops at the drawer border colour assertion that already fails onmain.quota-pwa-layoutandglobal-layoutpass.visual-feedback,appearance-sorting,report-preferencesandsync-refreshstop at assertions that fail identically onmainbefore this change. Their account-related parts were updated and passed when those older steps were bypassed in a temporary copy.🤖 Generated with Claude Code