SacessOptimizer: expose more hyperparameters #1459
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## develop #1459 +/- ##
===========================================
- Coverage 83.44% 83.39% -0.05%
===========================================
Files 160 160
Lines 13474 13499 +25
===========================================
+ Hits 11243 11258 +15
- Misses 2231 2241 +10 ☔ View full report in Codecov by Sentry. |
724bf84
to
5c7aa6e
Compare
PaulJonasJost
approved these changes
Sep 16, 2024
stephanmg
approved these changes
Sep 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduces a new SacessOptions class to collect SacessOptimizer hyperparameters and makes some previously hard-coded values configurable.
Closes SacessOptimizer - expose more hyperparameters #1458
Fixes a mismatch in adaptation conditions between the original SaCeSS implementation and SacessOptimizer