Feature - Multiple Database Connnection #61

dkiswanto · 2019-08-27T09:52:51Z

todo:

update readme
add an example for multiple connections

dkiswanto · 2019-08-27T09:57:33Z

adapter/postgres/postgres.go

@@ -57,7 +57,17 @@ func (adapter *Adapter) Insert(query grimoire.Query, changes map[string]interfac
 		ID int64
 	}

-	_, err := adapter.Query(&result, statement, args, loggers...)
+	// use query to get insert ids for postgres


should we wrap this as a new function??

coz it has identical statements in InsertAll below.

maybe a good idea

dkiswanto

will fix the ci later after the design pattern is reviewed

Fs02 · 2019-08-27T12:35:21Z

adapter/postgres/postgres.go

@@ -57,7 +57,17 @@ func (adapter *Adapter) Insert(query grimoire.Query, changes map[string]interfac
 		ID int64
 	}

-	_, err := adapter.Query(&result, statement, args, loggers...)
+	// use query to get insert ids for postgres


maybe a good idea

Fs02 · 2019-08-27T12:44:14Z

adapter/sql/connection.go

+
+// NewConnection for sql database
+func NewConnection(driver, dsns string) (*Connection, error) {
+	db, err := nap.Open(driver, dsns)


maybe we can detect wether nap is required or not here by checking the dsn pattern.
if it's not using a master-slave configuration, I think we can just use standard sql.DB instance to avoid unnecessary complexity.

draft multiple db connection

25faac8

dkiswanto commented Aug 27, 2019

View reviewed changes

Fs02 reviewed Aug 27, 2019

View reviewed changes

dkiswanto closed this Feb 13, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Feature - Multiple Database Connnection #61

Feature - Multiple Database Connnection #61

Feature - Multiple Database Connnection #61

Feature - Multiple Database Connnection #61

Conversation

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment