Adding a dynamic stress (wave model) to wall_models #1233
Conversation
|
@ayalamanuel do you have any updates on this? |
|
@marchdf Old files have been updated. Unit test, regression test and documentation have been added. Thanks! |
|
I've made the modifications to all the comments made @marchdf |
|
A meta comment here: to get past the CI check, the first thing you need to do is format your code. You can do that automatically with clang-format: https://exawind.github.io/amr-wind/developer/coding_guidelines.html#style-guide-recommendations |
7489570
to
38bdbe7
Compare
| tau.get_shear( | ||
| vv, wspd, u_dx, v_dx, xc, 1) / | ||
| mu * den(i, j, k); | ||
| } else { |
There was a problem hiding this comment.
I'm curious, when do we expect this branch to occur?
There was a problem hiding this comment.
Looking through the changes, did this get resolved?
There was a problem hiding this comment.
I believe it did get solve. Or perhaps I am not understanding the issue
There was a problem hiding this comment.
I'm trying to figure out when this branch will occur with all the new interpolation changes.
|
Can I do anything to help push this through? We are super close I think. |
|
@marchdf @moprak-nrel sorry for taking so long with this! Hopefully it's almost finished |
|
can you resolve those documentation conflicts? |
|
seems like the documentation issues are because I used and outdated theory.rst file. How can I update that file in my branch? then I can just add the once again the new part of documentation from my implementation |
I would rebase your branch with the latest amr-wind main and resolve any conflicts there. You'll need to do this before the PR is ready for merging anyway. |
7b7a2d2
to
a56074d
Compare
Summary
We have introduced a dynamic stress as a wall model. the dynamic stress calculates the stress due to waves. a new struct was implemented in ShearStressSimple.H where the wave stress is calculated. a new header (MOSD.H) was created with the calculations of the stress. the WallFunction.cpp has been modified accordingly.
Unit testing (test_mosd.cpp) and regression testing (channel_mosd.inp) using CPU has been done and added. The documentation of the model has also been added in the inputs_Boundary_conditions.rst file.
Pull request type
Please check the type of change introduced:
Checklist
The following is included:
This PR was tested by running:
Additional background
Issue Number: