8000 Fix banner and documentation figure overlaps by DaoyuanLi2816 · Pull Request #125 · DaoyuanLi2816/mini-verl · GitHub
[go: up one dir, main page]

Skip to content

Fix banner and documentation figure overlaps - #125

Merged
DaoyuanLi2816 merged 5 commits into
mainfrom
fix/visual-overlap-integrity
Sep 13, 2026
Merged

DaoyuanLi2816 merged 5 commits into
mainfrom
fix/visual-overlap-integrity

Conversation

@DaoyuanLi2816
@DaoyuanLi2816 DaoyuanLi2816 commented Sep 13, 2026 •
Copy link
Copy Markdown
Owner

Changes

  • Repair banner/card collisions and add a mobile banner in both READMEs.
  • Separate workload numbers from bars; move grid lines away from annotations; keep labels clear under wider fallback fonts and browser scaling.
  • Audit all 27 native SVGs plus both README figure galleries. Check untagged connectors, cards and markers, fully covering shapes and actual rendered font sizes.
  • Regenerate SVG projections only. Stable-site presentation updates require byte-identical frozen scientific inputs; release tags and package versions stay unchanged.

Validation

  • Local full non-GPU/non-network suite: 2,826 passed, 10 platform skips; 82% overall coverage. Latest figure/publication/packaging regression subset: 163 passed.
  • Complete Chromium gate: 52 rendered SVG instances across 1440, 1024, 820 and 390 px viewports, plus 27 native SVGs. Screenshots manually inspected. Wider-font native audit also passes all 27.
  • Ruff check/format, mypy, actionlint, strict MkDocs, Markdown/text checks, generator byte comparisons, wheel/sdist build and twine checks pass.
  • Stable-tag docs build and scientific-input-verified SVG overlay rehearsed locally.
  • CI screenshots: docs-visual-screenshots artifact on the docs workflow.
  • All frozen result/evidence files remain byte-identical to the base. Calculator SHA-256: 53fc1d4d5b7adee09618d77ad62d4086ba56b78569832d6fc7c3bcd5c2695bbc.

No training/runtime behavior, measured results, negative conclusions or published versions changed. Merge only after the exact head is green.

@DaoyuanLi2816
DaoyuanLi2816 marked this pull request as ready for review September 13, 2026 04:04
@DaoyuanLi2816
DaoyuanLi2816 merged commit 25ca0ba into main Sep 13, 2026
16 checks passed
@DaoyuanLi2816
DaoyuanLi2816 deleted the fix/visual-overlap-integrity branch September 13, 2026 04:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

0