-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix globe baselayer error #12274
Fix globe baselayer error #12274
Conversation
Thank you for the pull request, @Masty88! ✅ We can confirm we have a CLA on file for you. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR @Masty88!
Looks goods @Masty88! I just made a small tweak to move your Once CI passes, this should be good to merge. Thanks! |
Perfect thank you! |
Description
This PR adds a check to prevent using
baseLayer
whenglobe
is disabled, which would cause render errors.The check throws a
DeveloperError
with a clear message to help developers understand and fix the issue.The fix:
DeveloperError
with clear message when attempting to use baseLayer with globe: falseIssue number and link
Fixes #12244
Testing plan
Added two new test cases in ViewerSpec.js:
Additional testing:
Author checklist
CONTRIBUTORS.md
CHANGES.md
with "Fixed error when using baseLayer with globe disabled"