Repository navigation
python scripts to run checksums - #80
Merged
Merged
Conversation
subkanthi
reviewed
Sep 13, 2022
| return (query, select, order_by_columns, external_column_types) | ||
|
|
||
|
|
||
| def selectTableStatements(table, query, select_query, order_by, external_column_types): |
Collaborator
There was a problem hiding this comment.
can we please change this to snake case, so its consistent.
subkanthi
requested changes
Sep 13, 2022
| return res | ||
|
|
||
|
|
||
| def getTableChecksumQuery(table): |
Collaborator
There was a problem hiding this comment.
can we please change this to snake case, so its consistent.
| return (rowset, rowcount) | ||
|
|
||
|
|
||
| def executeStatement(strSql): |
Collaborator
There was a problem hiding this comment.
can we please change this to snake case, so its consistent.
Collaborator
There was a problem hiding this comment.
fill fix this in a separate PR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Python code to compute checksums between MySQL and CH